Fix DramKV race: hold rlock during inplace update writes (#5807)#5807
Closed
q10 wants to merge 1 commit into
Closed
Fix DramKV race: hold rlock during inplace update writes (#5807)#5807q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
Contributor
Summary: Pull Request resolved: pytorch#5807 X-link: https://github.com/facebookresearch/FBGEMM/pull/2733 Previously the rlock was released after collecting hit/miss info, then block pointers were written to without the lock held. This allowed eviction to invalidate block pointers during writes. Fix by keeping the rlock held through the entire read-and-write phase using scoped lifetime. Pull Request resolved: pytorch#5536 Test Plan: Imported from GitHub, without a `Test Plan:` line. Split from D95983752 Reviewed By: r-barnes Differential Revision: D98427441 Pulled By: q10
meta-codesync
Bot
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2733
Previously the rlock was released after collecting hit/miss info, then block pointers were written to without the lock held. This allowed eviction to invalidate block pointers during writes. Fix by keeping the rlock held through the entire read-and-write phase using scoped lifetime.
Test Plan:
Imported from GitHub, without a
Test Plan:line.Split from D95983752
Reviewed By: r-barnes
Differential Revision: D98427441
Pulled By: q10