Fix deadline/flaky + suppress GPU-only opcheck SKIPPING (OMH round 2) (#5932)#5932
Closed
q10 wants to merge 1 commit into
Closed
Fix deadline/flaky + suppress GPU-only opcheck SKIPPING (OMH round 2) (#5932)#5932q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109040643. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jun 19, 2026
…pytorch#5932) Summary: Second round of fbgemm_dev OMH test-health fixes (T191384137). After the first residual stack, the dashboard reopened with ~60-100+ records that the actual failure logs (meta testinfra) showed were NOT numeric regressions but three mechanical artifacts. This diff fixes the two that are fbgemm's to own. 1. FLAKY (deadline cold-start): every sampled FLAKY failed with hypothesis DeadlineExceeded -> FlakyFailure because the first GPU call in a fresh stress-run process pays 12-27s of CUDA/Triton/JIT cold-start, blowing the settings(deadline=10000). Set deadline=None (what hypothesis recommends; already the convention in 287 sibling fbgemm tests) on the affected GPU hypothesis tests: bfloat16, fused_8bit_rowwise, fused_nbit_rowwise, mixed_dim_int8, hfp8, msfp, permute_pooled_embedding. 2. kmeans bf16 centroids: the bf16 branch kept the tight rtol=2e-3/atol=2e-2 while only fp32 was widened earlier; bf16 GPU atomicAdd order is nondeterministic (~0.023 abs / 0.046 rel) -> FlakyFailure. Widen to 5e-2. 3. SSD inference test_sequence_table_simple_forward: failed HealthCheck.too_slow (each example builds a RocksDB table + GPU forward, 15-33s). Suppress too_slow and cap max_examples=20. 4. block_bucketize test_aot_dispatch_dynamic__...sparse_features_large: 600s tpx timeout from per-example PT2 recompile (my_size up to 1024). Scoped skip of the aot variant in failures_dict (eager + faketensor still cover the op). 5. SKIPPING: ~16 GPU-only base tests (gated skipIf(gpu_unavailable)) generate opcheck variants that only SKIP on CPU/non-NVIDIA samples and add no op coverage (op is covered by non-gated / *_cpu twin tests). Mark them optests.dontGenerateOpCheckTests so the variants are never generated, the same pattern already used for permute_indices *_large_grid. Covers permute_indices (6 methods), index_select (3), pack_segments (3), reorder_batched (3), histogram_binning_calibration (1). NOTE: a separate cluster of ~70 preproc_legacy_comparison:test_op_* FAILUREs is an EXTERNAL MTIA KernelsDB build break (mtia/kernels_db duplicate acc_ops.square, D108088144) and is not addressed here. Differential Revision: D109040643
a25b88d to
fc58d8b
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jun 20, 2026
…pytorch#5932) Summary: X-link: facebookresearch/FBGEMM#2850 Second round of fbgemm_dev OMH test-health fixes (T191384137). After the first residual stack, the dashboard reopened with ~60-100+ records that the actual failure logs (meta testinfra) showed were NOT numeric regressions but three mechanical artifacts. This diff fixes the two that are fbgemm's to own. 1. FLAKY (deadline cold-start): every sampled FLAKY failed with hypothesis DeadlineExceeded -> FlakyFailure because the first GPU call in a fresh stress-run process pays 12-27s of CUDA/Triton/JIT cold-start, blowing the settings(deadline=10000). Set deadline=None (what hypothesis recommends; already the convention in 287 sibling fbgemm tests) on the affected GPU hypothesis tests: bfloat16, fused_8bit_rowwise, fused_nbit_rowwise, mixed_dim_int8, hfp8, msfp, permute_pooled_embedding. 2. kmeans bf16 centroids: the bf16 branch kept the tight rtol=2e-3/atol=2e-2 while only fp32 was widened earlier; bf16 GPU atomicAdd order is nondeterministic (~0.023 abs / 0.046 rel) -> FlakyFailure. Widen to 5e-2. 3. SSD inference test_sequence_table_simple_forward: failed HealthCheck.too_slow (each example builds a RocksDB table + GPU forward, 15-33s). Suppress too_slow and cap max_examples=20. 4. block_bucketize test_aot_dispatch_dynamic__...sparse_features_large: 600s tpx timeout from per-example PT2 recompile (my_size up to 1024). Scoped skip of the aot variant in failures_dict (eager + faketensor still cover the op). 5. SKIPPING: ~16 GPU-only base tests (gated skipIf(gpu_unavailable)) generate opcheck variants that only SKIP on CPU/non-NVIDIA samples and add no op coverage (op is covered by non-gated / *_cpu twin tests). Mark them optests.dontGenerateOpCheckTests so the variants are never generated, the same pattern already used for permute_indices *_large_grid. Covers permute_indices (6 methods), index_select (3), pack_segments (3), reorder_batched (3), histogram_binning_calibration (1). NOTE: a separate cluster of ~70 preproc_legacy_comparison:test_op_* FAILUREs is an EXTERNAL MTIA KernelsDB build break (mtia/kernels_db duplicate acc_ops.square, D108088144) and is not addressed here. Differential Revision: D109040643
…pytorch#5932) Summary: X-link: facebookresearch/FBGEMM#2850 Second round of fbgemm_dev OMH test-health fixes (T191384137). After the first residual stack, the dashboard reopened with ~60-100+ records that the actual failure logs (meta testinfra) showed were NOT numeric regressions but three mechanical artifacts. This diff fixes the two that are fbgemm's to own. 1. FLAKY (deadline cold-start): every sampled FLAKY failed with hypothesis DeadlineExceeded -> FlakyFailure because the first GPU call in a fresh stress-run process pays 12-27s of CUDA/Triton/JIT cold-start, blowing the settings(deadline=10000). Set deadline=None (what hypothesis recommends; already the convention in 287 sibling fbgemm tests) on the affected GPU hypothesis tests: bfloat16, fused_8bit_rowwise, fused_nbit_rowwise, mixed_dim_int8, hfp8, msfp, permute_pooled_embedding. 2. kmeans bf16 centroids: the bf16 branch kept the tight rtol=2e-3/atol=2e-2 while only fp32 was widened earlier; bf16 GPU atomicAdd order is nondeterministic (~0.023 abs / 0.046 rel) -> FlakyFailure. Widen to 5e-2. 3. SSD inference test_sequence_table_simple_forward: failed HealthCheck.too_slow (each example builds a RocksDB table + GPU forward, 15-33s). Suppress too_slow and cap max_examples=20. 4. block_bucketize test_aot_dispatch_dynamic__...sparse_features_large: 600s tpx timeout from per-example PT2 recompile (my_size up to 1024). Scoped skip of the aot variant in failures_dict (eager + faketensor still cover the op). 5. SKIPPING: ~16 GPU-only base tests (gated skipIf(gpu_unavailable)) generate opcheck variants that only SKIP on CPU/non-NVIDIA samples and add no op coverage (op is covered by non-gated / *_cpu twin tests). Mark them optests.dontGenerateOpCheckTests so the variants are never generated, the same pattern already used for permute_indices *_large_grid. Covers permute_indices (6 methods), index_select (3), pack_segments (3), reorder_batched (3), histogram_binning_calibration (1). NOTE: a separate cluster of ~70 preproc_legacy_comparison:test_op_* FAILUREs is an EXTERNAL MTIA KernelsDB build break (mtia/kernels_db duplicate acc_ops.square, D108088144) and is not addressed here. Differential Revision: D109040643
Contributor
|
This pull request has been merged in b91d17c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2850
Second round of fbgemm_dev OMH test-health fixes (T191384137). After the first
residual stack, the dashboard reopened with ~60-100+ records that the actual
failure logs (meta testinfra) showed were NOT numeric regressions but three
mechanical artifacts. This diff fixes the two that are fbgemm's to own.
FLAKY (deadline cold-start): every sampled FLAKY failed with
hypothesis DeadlineExceeded -> FlakyFailure because the first GPU call in a
fresh stress-run process pays 12-27s of CUDA/Triton/JIT cold-start, blowing
the settings(deadline=10000). Set deadline=None (what hypothesis recommends;
already the convention in 287 sibling fbgemm tests) on the affected GPU
hypothesis tests: bfloat16, fused_8bit_rowwise, fused_nbit_rowwise,
mixed_dim_int8, hfp8, msfp, permute_pooled_embedding.
kmeans bf16 centroids: the bf16 branch kept the tight rtol=2e-3/atol=2e-2
while only fp32 was widened earlier; bf16 GPU atomicAdd order is
nondeterministic (~0.023 abs / 0.046 rel) -> FlakyFailure. Widen to 5e-2.
SSD inference test_sequence_table_simple_forward: failed
HealthCheck.too_slow (each example builds a RocksDB table + GPU forward,
15-33s). Suppress too_slow and cap max_examples=20.
block_bucketize test_aot_dispatch_dynamic__...sparse_features_large: 600s tpx
timeout from per-example PT2 recompile (my_size up to 1024). Scoped skip of
the aot variant in failures_dict (eager + faketensor still cover the op).
SKIPPING: ~16 GPU-only base tests (gated skipIf(gpu_unavailable)) generate
opcheck variants that only SKIP on CPU/non-NVIDIA samples and add no op
coverage (op is covered by non-gated / *_cpu twin tests). Mark them
optests.dontGenerateOpCheckTests so the variants are never generated, the
same pattern already used for permute_indices *_large_grid. Covers
permute_indices (6 methods), index_select (3), pack_segments (3),
reorder_batched (3), histogram_binning_calibration (1).
NOTE: a separate cluster of ~70 preproc_legacy_comparison:test_op_* FAILUREs is
an EXTERNAL MTIA KernelsDB build break (mtia/kernels_db duplicate acc_ops.square,
D108088144) and is not addressed here.
Differential Revision: D109040643