Fix backward_dense health-check regression under the ci profile#5936
Open
gchalump wants to merge 1 commit into
Open
Fix backward_dense health-check regression under the ci profile#5936gchalump wants to merge 1 commit into
gchalump wants to merge 1 commit into
Conversation
Contributor
|
@gchalump has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109164907. |
Summary: test_backward_dense regressed in OSS CI on 2026-06-15 (green before). D108096684 removed the per-test suppress_health_check from backward_dense_test.py and moved it into the "derandomize" Hypothesis profile. OSS CI runs under the "ci" profile, not "derandomize", so the suppression never applied -- the job log shows `hypothesis profile 'ci' -> suppress_health_check=(HealthCheck.too_slow,)`. The test's heavy assume() usage then trips HealthCheck.filter_too_much and fails. Fix: apply suppress_health_check explicitly in settings via the centralized suppressed_list from tbe/common.py, making it independent of the active profile while keeping a single source of truth. Differential Revision: D109164907
gchalump
force-pushed
the
export-D109164907
branch
from
9ca82f8 to
340a475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
test_backward_dense regressed in OSS CI on 2026-06-15 (green before). D108096684
removed the per-test suppress_health_check from backward_dense_test.py and moved
it into the "derandomize" Hypothesis profile. OSS CI runs under the "ci"
profile, not "derandomize", so the suppression never applied -- the job log
shows
hypothesis profile 'ci' -> suppress_health_check=(HealthCheck.too_slow,).The test's heavy assume() usage then trips HealthCheck.filter_too_much and fails.
Fix: apply suppress_health_check explicitly in settings via the centralized
suppressed_list from tbe/common.py, making it independent of the active profile
while keeping a single source of truth.
Differential Revision: D109164907