fix(_is_mslk_available): guard against missing CUDA/ROCm runtime#4544
Open
space192 wants to merge 2 commits into
Open
fix(_is_mslk_available): guard against missing CUDA/ROCm runtime#4544space192 wants to merge 2 commits into
space192 wants to merge 2 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4544
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:
Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_mslk_available()crashes withOSErrorwhen mslk is installed but no CUDA/ROCm runtime is present (e.g. CPU-only submission nodes).The function is called at module level in
torchao/quantization/quantize_/workflows/float8/float8_tensor.py, so the crash propagates through any transitive import chain that touches torchao — includingtransformers,vllm, etc. — even when the user never explicitly imports mslk or uses FP8.Repro:
Fix
Check
torch.cuda.is_available()before attemptingimport mslk. This covers both CUDA and ROCm (HIP maps to the CUDA API surface). A warning is emitted so users know mslk was skipped and why.Test plan
import torchaosucceeds with a warning instead of crashing.