Skip to content

Commit e284e58

Browse files
authored
Remove pinning against torch version (#4171)
1 parent e123269 commit e284e58

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

setup.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,12 @@ def _main():
8686
print("-- Git branch:", branch)
8787
print("-- Git SHA:", sha)
8888
print("-- Git tag:", tag)
89-
pytorch_package_dep = _get_pytorch_version()
90-
print("-- PyTorch dependency:", pytorch_package_dep)
89+
# This used to be passed to install_requires
90+
# which would cause pinning against a specific torch version in releases.
91+
# I don't think we want to pin at all?
92+
# TODO: revisit if needed. Maybe it's needed for nightlies. Unsure.
93+
# pytorch_package_dep = _get_pytorch_version()
94+
# print("-- PyTorch dependency:", pytorch_package_dep)
9195
version = _get_version(sha)
9296
print("-- Building version", version)
9397

@@ -135,7 +139,7 @@ def _main():
135139
"build_ext": setup_helpers.get_build_ext(),
136140
"clean": clean,
137141
},
138-
install_requires=[pytorch_package_dep],
142+
install_requires=[],
139143
zip_safe=False,
140144
)
141145

0 commit comments

Comments
 (0)