Annotate kaldi.vtln_warp_mel_freq low_freq as float for TorchScript#4195
Open
adityasingh2400 wants to merge 1 commit into
Open
Annotate kaldi.vtln_warp_mel_freq low_freq as float for TorchScript#4195adityasingh2400 wants to merge 1 commit into
adityasingh2400 wants to merge 1 commit into
Conversation
src/torchaudio/compliance/kaldi.py vtln_warp_mel_freq accepted low_freq without a type annotation, so torch.jit.script could not lower it while every other param in the signature was annotated. Add : float to bring it in line. Fixes pytorch#3729
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4195
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torchaudio.compliance.kaldi.vtln_warp_mel_freqacceptedlow_freqwithout a type annotation, while every other parameter in the signature (vtln_low_cutoff,vtln_high_cutoff,high_freq,vtln_warp_factor,mel_freq) was annotated. Without the hint,torch.jit.scriptinfersTensorand refuses to lower the function, blocking TorchScript export of any model that exercises this path.The sibling
vtln_warp_freqfunction (line 337) already annotateslow_freq: float, so this matches existing convention.Change
One-token addition of
: floatto thelow_freqparameter.def vtln_warp_mel_freq( vtln_low_cutoff: float, vtln_high_cutoff: float, - low_freq, + low_freq: float, high_freq: float, vtln_warp_factor: float, mel_freq: Tensor, ) -> Tensor:The existing docstring already documents the parameter as
low_freq (float), so behaviour and documentation are unchanged. Runtime behaviour is unchanged; this is purely a TorchScript compatibility fix.Fixes #3729