-
Notifications
You must be signed in to change notification settings - Fork 27.8k
Erroneous Conda Windows MKL dependency #126279
Copy link
Copy link
Closed
pytorch/builder
#1830Labels
module: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to usersmodule: intelSpecific to x86 architectureSpecific to x86 architecturemodule: mklRelated to our MKL supportRelated to our MKL supportmodule: windowsWindows support for PyTorchWindows support for PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Metadata
Metadata
Assignees
Labels
module: binariesAnything related to official binaries that we release to usersAnything related to official binaries that we release to usersmodule: intelSpecific to x86 architectureSpecific to x86 architecturemodule: mklRelated to our MKL supportRelated to our MKL supportmodule: windowsWindows support for PyTorchWindows support for PyTorchtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
Done
pytorch/setup.py
Line 1112 in a0aaf56
This line adds a dependency to the python package on
mkl >=2021.1.1,<=2021.4.0on windows. However, the built conda packages do not align with this requirement.For instance take the conda package
win-64_pytorch-2.3.0-py3.12_cuda11.8_cudnn8_0:The PKG_INFO inside the package lists:
However the
index.jsonhas:Running pip-check will fail.
However, the conda package
win-64_pytorch-2.3.0-py3.9_cuda11.8_cudnn8_0(note thepy3.9) does specify:I think its because of these lines in the
meta.yaml:https://github.com/pytorch/builder/blob/a4b440ec0f687c84d089310d68ae3345d6eca7fc/conda/pytorch-nightly/meta.yaml#L26-27
Regardless, I think this dependency should depend on the BLAS implementation chosen, if BLAS is not set to mkl I think this dependency shouldn't be there in the first place.
cc @seemethere @malfet @osalpekar @atalman @peterjc123 @mszhanyi @skyline75489 @nbcsm @vladimir-aubrecht @iremyux @Blackhex @cristianPanaite @frank-wei @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10