Commit 0c763d2
[ET-VK][conv2d_dw] Fix test requesting nonexistent sned b1x1 shader
The test_conv2d_dw benchmark aborted on device (SIGABRT) with an uncaught vkcompute::vkapi::Error from ShaderRegistry::get_shader_info: "Could not find ShaderInfo with name conv2d_dw_sned_output_tile_3x3_b1x1_float". pick_conv2d_dw_shader_with_selector in TestConv2dDw.cpp appended the _b1x1 batch-tile infix for any 3x3 case whenever impl_selector == "b1x1", with no stride_equals_dilation guard. For a strided 3x3 case it had already appended _sned, producing conv2d_dw_sned_output_tile_3x3_b1x1_float — a variant the sned shader family never generates (sned shaders are not batch-tiled; only the non-sned conv2d_dw_output_tile family has _b1x1 variants).
This guards the forced _b1x1 append on stride_equals_dilation, matching the production pick_conv2d_dw_shader in Conv2dDW.cpp. A forced b1x1 selector on a strided 3x3 case now falls back to the existing un-suffixed sned shader instead of requesting an unbacked variant.
Differential Revision: [D108916041](https://our.internmc.facebook.com/intern/diff/D108916041/)
ghstack-source-id: 394480011
Pull-Request: #203431 parent 0da9ca3 commit 0c763d2
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
57 | 63 | | |
58 | 64 | | |
59 | 65 | | |
| |||
0 commit comments