Skip to content

Commit 2b6baec

Browse files
author
ssjia
committed
Update on "[ET-VK][ez] Implement helper functions to get fastest moving dim"
Add C++ and GLSL helpers to query the fastest moving dimension (the dimension with stride 1 in buffer layout). This is useful for optimizing memory access patterns in shaders, as iterating along the fastest moving dimension maximizes cache locality. The C++ `fastest_whcn_dim()` method accounts for block-transposed layouts by returning `outer_packed_dim` instead of `packed_dim` when applicable. A corresponding GLSL macro extracts this info from the hashed layout. Differential Revision: [D92061369](https://our.internmc.facebook.com/intern/diff/D92061369/) [ghstack-poisoned]
2 parents 0c0b205 + 4690ed8 commit 2b6baec

4 files changed

Lines changed: 1 addition & 313 deletions

File tree

.github/workflows/pull.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1137,7 +1137,7 @@ jobs:
11371137
./cmake-out/backends/vulkan/test/custom_ops/q8csw_conv2d
11381138
./cmake-out/backends/vulkan/test/custom_ops/q4gsw_linear
11391139
./cmake-out/backends/vulkan/test/custom_ops/choose_qparams_per_row
1140-
./cmake-out/backends/vulkan/test/custom_ops/qdq8ta_conv2d_activations
1140+
./cmake-out/backends/vulkan/test/custom_ops/test_q8ta_qdq
11411141
./cmake-out/backends/vulkan/test/custom_ops/q8ta_q8ta_q8to_add
11421142
11431143
# "Classic" Operator tests

backends/vulkan/test/custom_ops/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ if(TARGET vulkan_backend)
9797
add_operator_prototype(q8csw_conv2d)
9898
add_operator_prototype(q4gsw_linear)
9999
add_operator_prototype(choose_qparams_per_row)
100-
add_operator_prototype(qdq8ta_conv2d_activations)
101100
add_operator_prototype(test_q8ta_qdq)
102101
add_operator_prototype(q8ta_q8csw_q8to_conv2d)
103102
add_operator_prototype(q8ta_q8csw_q8to_conv2d_dw)

backends/vulkan/test/custom_ops/qdq8ta_conv2d_activations.cpp

Lines changed: 0 additions & 310 deletions
This file was deleted.

backends/vulkan/test/custom_ops/targets.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ def define_common_targets(is_fbcode = False):
9191
define_custom_op_test_binary("q8csw_conv2d")
9292
define_custom_op_test_binary("choose_qparams_per_row")
9393
define_custom_op_test_binary("q4gsw_linear")
94-
define_custom_op_test_binary("qdq8ta_conv2d_activations")
9594
define_custom_op_test_binary("test_q8ta_qdq")
9695
define_custom_op_test_binary("q8ta_q8csw_q8to_conv2d")
9796
define_custom_op_test_binary("q8ta_q8csw_q8to_conv2d_dw")

0 commit comments

Comments
 (0)