Commit 2f0837e
Add missing runner_lib dep to main_static (#19210)
Summary:
D82497138 added new transitive includes (`constants.h`, `multimodal_prefiller.h`, `extension/tensor/tensor.h`) into `executorch/extension/llm/runner/util.h`. The llava `main.cpp` already includes `multimodal_runner.h`, `multimodal_input.h`, and `image.h`, and calls `create_multimodal_runner` and `load_tokenizer` from `llm_runner_helper`, but the `main` (and auto-generated `main_static`) target only declared `print_evalue` and `threadpool` deps. After D82497138 the compile fails with `Action failed: ... (cxx_compile main.cpp) Remote command returned non-zero exit code 1` because the `runner_lib` headers cannot be found.
Add `//executorch/extension/llm/runner:runner_lib` (which transitively re-exports `multimodal_runner_lib` and provides `llm_runner_helper`) to the deps of the `main` cxx_binary so the static variant resolves all required headers and symbols. Also wire the existing `seq_len` flag into `GenerationConfig::seq_len` (it was previously read from gflags but never used, which trips `-Werror=unused-variable` once the headers compile).
Reviewed By: psiddh
Differential Revision: D1030285011 parent 2050b8a commit 2f0837e
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
0 commit comments