Skip to content

Commit 321175b

Browse files
committed
Third-party: Disable -Werror for flatcc build
Apple Clang 21 (Xcode 26) elevates -Wimplicit-int-conversion-on-negation and -Wunterminated-string-initialization to errors, which breaks the vendored flatcc build at pprintint.h and grisu3_print.h. The warnings are benign and the fix belongs upstream in dvidelabs/flatcc; disable -Werror locally via FLATCC_ALLOW_WERROR=OFF for both the flatcc_ep external project (host compiler) and the in-tree flatccrt runtime lib. Authored with Claude.
1 parent e6efe18 commit 321175b

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

third-party/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ ExternalProject_Add(
9191
-DFLATCC_TEST=OFF
9292
-DFLATCC_REFLECTION=OFF
9393
-DFLATCC_DEBUG_CLANG_SANITIZE=OFF
94+
-DFLATCC_ALLOW_WERROR=OFF
9495
-DFLATCC_INSTALL=ON
9596
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
9697
-DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
@@ -116,6 +117,7 @@ set(FLATCC_RTONLY ON CACHE BOOL "")
116117
set(FLATCC_TEST OFF CACHE BOOL "")
117118
set(FLATCC_REFLECTION OFF CACHE BOOL "")
118119
set(FLATCC_DEBUG_CLANG_SANITIZE OFF CACHE BOOL "")
120+
set(FLATCC_ALLOW_WERROR OFF CACHE BOOL "")
119121
set(FLATCC_INSTALL OFF CACHE BOOL "")
120122
add_subdirectory(flatcc)
121123
# Unfortunately flatcc writes libs directly in to the source tree [1]. So to

0 commit comments

Comments
 (0)