Skip to content

Commit 39cd25d

Browse files
committed
Update base for Update on "[Executorch][LLM] Use caching allocator for runner"
We observed that on iOS it improves perf by 6% because SDPA op does temp allocations. No significant difference on android though. Differential Revision: [D86120038](https://our.internmc.facebook.com/intern/diff/D86120038/) [ghstack-poisoned]
1 parent a4912c5 commit 39cd25d

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

extension/memory_allocator/test/cpu_caching_malloc_allocator_test.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -330,12 +330,8 @@ TEST_F(CPUCachingAllocatorTest, ResetFreesEverythingWhenOverMaxSize) {
330330
EXPECT_NE(p5, nullptr);
331331

332332
// These should be new allocations, not cached ones
333-
EXPECT_NE(p4, p1);
334-
EXPECT_NE(p4, p2);
335-
EXPECT_NE(p4, p3);
336-
EXPECT_NE(p5, p1);
337-
EXPECT_NE(p5, p2);
338-
EXPECT_NE(p5, p3);
333+
// However, system allocator might cache and return the same pointesr
334+
// so we can't check for strict equality or inequality
339335
}
340336

341337
TEST_F(CPUCachingAllocatorTest, ResetCachesWhenUnderMaxSize) {

0 commit comments

Comments
 (0)