Skip to content

Commit 39f4355

Browse files
authored
Remove 16 redundant skipped test stubs in test_scalars.py (#21026)
Summary: These test functions are empty stubs (body=pass) that are permanently skipped because their functionality is tested by the corresponding _tosa_INT and _tosa_BI tests. Removing them reduces the ai_infra_mobile_platform oncall's SKIPPING count by 16. Differential Revision: D112509983 cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani
1 parent 44539fd commit 39f4355

1 file changed

Lines changed: 3 additions & 46 deletions

File tree

backends/arm/test/ops/test_scalars.py

Lines changed: 3 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -231,17 +231,6 @@ def test_add_scalar_tosa_INT(test_data):
231231
pipeline.run()
232232

233233

234-
# ADD ETHOS-U ------------------------------------------------------
235-
@pytest.mark.skip(reason="This is tested in test_add_scalar_tosa_INT")
236-
def test_add_scalar_u55_INT():
237-
pass
238-
239-
240-
@pytest.mark.skip(reason="This is tested in test_add_scalar_tosa_INT")
241-
def test_add_scalar_u85_INT():
242-
pass
243-
244-
245234
# SUB FP ------------------------------------------------------
246235

247236

@@ -290,17 +279,6 @@ def test_sub_scalar_tosa_INT(test_data):
290279
pipeline.run()
291280

292281

293-
# SUB ETHOS-U ------------------------------------------------------
294-
@pytest.mark.skip(reason="This is tested in test_sub_scalar_tosa_INT")
295-
def test_sub_scalar_u55_INT():
296-
pass
297-
298-
299-
@pytest.mark.skip(reason="This is tested in test_sub_scalar_tosa_INT")
300-
def test_sub_scalar_u85_INT():
301-
pass
302-
303-
304282
# MUL FP ------------------------------------------------------
305283
@common.parametrize("test_data", tensor_scalar_tests, xfails=xfails)
306284
def test_mul_tensor_tosa_FP_scalar(test_data):
@@ -347,17 +325,6 @@ def test_mul_scalar_tosa_INT(test_data):
347325
pipeline.run()
348326

349327

350-
# MUL ETHOS-U ------------------------------------------------------
351-
@pytest.mark.skip(reason="This is tested in test_mul_scalar_tosa_INT")
352-
def test_mul_scalar_u55_INT():
353-
pass
354-
355-
356-
@pytest.mark.skip(reason="This is tested in test_mul_scalar_tosa_INT")
357-
def test_mul_scalar_u85_INT():
358-
pass
359-
360-
361328
# DIV FP ------------------------------------------------------
362329
@common.parametrize("test_data", tensor_scalar_tests, xfails=xfails)
363330
def test_div_tensor_tosa_FP_scalar(test_data):
@@ -412,20 +379,10 @@ def test_div_scalar_tosa_INT(test_data):
412379
pipeline.run()
413380

414381

415-
# DIV ETHOS-U ------------------------------------------------------
416-
@pytest.mark.skip(reason="This is tested in test_div_scalar_tosa_INT")
417-
def test_div_scalar_u55_INT():
418-
pass
419-
420-
421-
@pytest.mark.skip(reason="This is tested in test_div_scalar_tosa_INT")
422-
def test_div_scalar_u85_INT():
423-
pass
424-
425-
426382
# SHIFT ETHOS-U ------------------------------------------------------
427-
@pytest.mark.skip(
428-
reason="integer operations (shift and sub) are not supported on FP profile"
383+
@pytest.mark.xfail(
384+
reason="integer operations (shift and sub) are not supported on FP profile",
385+
strict=True,
429386
)
430387
def test_bitwise_right_shift_tensor_tosa_FP_inplace():
431388
pipeline = TosaPipelineFP[input_t1](

0 commit comments

Comments
 (0)