Skip to content

Commit 4141453

Browse files
digantdesaimeta-codesync[bot]
digantdesai
authored and
meta-codesync[bot]
committed
Expand fbcode buck test coverage for arm backend (58→162 test targets) (#18817)
Summary: Pull Request resolved: #18817 Expand the arm backend test coverage in fbcode by adding all available test files from ops/, quantizer/, and misc/ directories to targets.bzl. Reviewed By: 3l1 Differential Revision: D96521268
1 parent 7825ffe commit 4141453

2 files changed

Lines changed: 138 additions & 4 deletions

File tree

‎backends/arm/operators/op_tosa_conv3d.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Conv3dVisitor(Conv2dVisitor):
1515
target = "tosa.CONV3D.default"
1616

1717
def _get_tosa_op(self):
18-
import serializer.tosa_serializer as ts # type: ignore
18+
import tosa_serializer as ts
1919

2020
return ts.Op.CONV3D
2121

‎backends/arm/test/targets.bzl‎

Lines changed: 137 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,133 @@ def define_arm_tests():
1616

1717
# Operators
1818
test_files += [
19+
"ops/test_abs.py",
1920
"ops/test_add.py",
2021
"ops/test_addmm.py",
22+
"ops/test_amax.py",
23+
"ops/test_amin.py",
2124
"ops/test_avg_pool2d.py",
25+
# "ops/test_batch_norm.py", # T000000 FVP reshape fails: dtype mismatch in output parsing (expected [3], got 12 elements)
26+
"ops/test_bitwise.py",
27+
"ops/test_bmm.py",
2228
"ops/test_cat.py",
29+
"ops/test_ceil.py",
30+
"ops/test_clamp.py",
31+
"ops/test_clone.py",
32+
"ops/test_conv1d.py",
2333
"ops/test_conv2d.py",
34+
"ops/test_conv3d.py",
35+
"ops/test_cos.py",
36+
# "ops/test_depthwise_conv.py", # T000000 Cross-file imports from test_conv1d/test_conv2d break Buck target listing
37+
# "ops/test_div.py", # 15 failures: NoneType input in bundled_program serialization (pre-existing bug)
38+
"ops/test_elu.py",
39+
"ops/test_embedding.py",
40+
"ops/test_eq.py",
41+
"ops/test_erf.py",
42+
"ops/test_exp.py",
43+
"ops/test_expand.py",
44+
"ops/test_floor.py",
45+
"ops/test_full.py",
46+
"ops/test_ge.py",
47+
"ops/test_group_norm.py",
48+
"ops/test_gt.py",
49+
"ops/test_hardswish.py",
50+
"ops/test_hardtanh.py",
51+
# "ops/test_layer_norm.py", # 1 failure: 16a8w u55 quantization issue
52+
"ops/test_le.py",
53+
"ops/test_leaky_relu.py",
2454
"ops/test_linear.py",
2555
"ops/test_log10.py",
56+
"ops/test_log.py",
57+
"ops/test_logical.py",
58+
"ops/test_lt.py",
59+
# matmul: Vela compilation fails with 'Non-passthrough operation'
60+
# for int16 matmul operations, xfail interacts incorrectly with
61+
# XfailIfNoCorstone.
62+
# "ops/test_matmul.py",
2663
"ops/test_max_pool1d.py",
64+
"ops/test_max_pool.py",
65+
"ops/test_mean_dim.py",
66+
"ops/test_maximum.py",
67+
"ops/test_minimum.py",
68+
"ops/test_mm.py",
2769
"ops/test_mul.py",
70+
"ops/test_ne.py",
71+
"ops/test_neg.py",
72+
"ops/test_ones.py",
2873
"ops/test_permute.py",
74+
"ops/test_pixel_shuffling.py",
75+
"ops/test_pow.py",
76+
"ops/test_reciprocal.py",
77+
"ops/test_relu.py",
78+
"ops/test_remainder.py",
79+
"ops/test_repeat.py",
80+
"ops/test_round.py",
81+
# rshift: U55 FVP output dtype mismatch for rshift operations,
82+
# xfail interacts incorrectly with XfailIfNoCorstone.
83+
# "ops/test_rshift.py",
2984
"ops/test_rsqrt.py",
30-
"ops/test_slice.py",
85+
"ops/test_rsub.py",
86+
"ops/test_scalar_tensor.py",
87+
"ops/test_scalars.py",
88+
"ops/test_sdpa.py",
89+
"ops/test_select.py",
90+
"ops/test_select_scatter.py",
3191
"ops/test_sigmoid.py",
92+
"ops/test_sigmoid_32bit.py",
93+
"ops/test_sign.py",
94+
# silu: U55 numerical mismatch for inplace SiLU, xfail interacts
95+
# incorrectly with XfailIfNoCorstone.
96+
# "ops/test_silu.py",
97+
"ops/test_sin.py",
98+
"ops/test_sinh.py",
99+
"ops/test_slice.py",
100+
# slice_scatter: U55/U85 FVP failures for int8 and end_none cases,
101+
# xfail interacts incorrectly with XfailIfNoCorstone.
102+
# "ops/test_slice_scatter.py",
103+
"ops/test_softmax.py",
104+
"ops/test_split.py",
105+
"ops/test_sqrt.py",
106+
"ops/test_squeeze.py",
107+
"ops/test_stack.py",
32108
"ops/test_sub.py",
109+
# sum: xfail markers interact incorrectly with XfailIfNoCorstone
110+
# when test inputs contain None (NoneType not supported in
111+
# bundled_program serialization).
112+
# "ops/test_sum.py",
113+
"ops/test_t_copy.py",
114+
"ops/test_tan.py",
33115
"ops/test_tanh.py",
34-
"ops/test_view.py",
35-
"ops/test_cos.py",
36116
"ops/test_to_copy.py",
117+
# transpose_conv2d: xfail markers for per-channel quantization
118+
# interact incorrectly with XfailIfNoCorstone when tests fail
119+
# during quantization (before reaching FVP execution).
120+
# "ops/test_transpose_conv2d.py",
121+
"ops/test_transpose_copy.py",
122+
"ops/test_tril.py",
123+
# "ops/test_unary_combos.py", # 1 failure: NegAdd u55_INT
124+
"ops/test_unbind.py",
125+
"ops/test_unflatten.py",
126+
"ops/test_unfold_copy.py",
127+
"ops/test_unsqueeze.py",
128+
"ops/test_upsample_bilinear2d.py",
129+
"ops/test_upsample_nearest2d.py",
130+
"ops/test_var.py",
131+
"ops/test_view.py",
132+
"ops/test_where.py",
133+
"ops/test_while.py",
134+
"ops/test_zeros.py",
37135
]
38136

39137
# Quantization
40138
test_files += [
139+
"quantizer/test_conv_relu_fusing.py",
41140
"quantizer/test_generic_annotater.py",
141+
"quantizer/test_partial_quantization.py",
142+
"quantizer/test_preserve_kwargs.py",
143+
# "quantizer/test_selective_quantization.py", # needs torchvision (not in deps)
144+
"quantizer/test_set_module_name.py",
145+
"quantizer/test_tosa_quantizer_validate.py",
42146
]
43147

44148
# Misc tests
@@ -48,15 +152,44 @@ def define_arm_tests():
48152
"misc/test_pass_pipeline_config.py",
49153
"misc/test_tosa_spec.py",
50154
"misc/test_bn_relu_folding_qat.py",
155+
"misc/test_call_operator_submodule.py",
156+
"misc/test_compile_spec.py",
157+
"misc/test_const_shape.py",
158+
"misc/test_conv_relu_residual_add.py",
159+
"misc/test_count_tosa_ops.py",
51160
"misc/test_custom_partition.py",
161+
"misc/test_debug_feats.py",
52162
"misc/test_debug_hook.py",
53163
"misc/test_post_quant_device_switch.py",
54164
# "misc/test_dim_order.py", (TODO - T238390249)
55165
]
56166

57167
# Deprecation tests
58168
test_files += [
169+
"misc/test_dw_convs_with_shared_weights.py",
170+
"misc/test_extract_io_params_tosa.py",
171+
# "misc/test_int64.py", # 5 failures: int64 overflow/chain handling issues
172+
"misc/test_lifted_tensor.py",
173+
"misc/test_mixed_fp_bf16_partition.py",
174+
"misc/test_mixed_type_lowering.py",
175+
# "misc/test_model_evaluator.py", # needs executorch.backends.arm.util (no BUCK target)
176+
"misc/test_multiple_delegates.py",
177+
"misc/test_multiple_outputs.py",
178+
"misc/test_non_persistent_buffers.py",
59179
"deprecation/test_arm_compile_spec_deprecation.py",
180+
"misc/test_partition_decomposed_quantized_ops.py",
181+
"misc/test_pass_pipeline_config.py",
182+
"misc/test_pass_required_order.py",
183+
"misc/test_qat_training_loop.py",
184+
"misc/test_quant_custom_meta.py",
185+
# "misc/test_rescale_range.py", # 3 failures: zero-point and rescale range validation
186+
# "misc/test_runner_utils.py", # name collides with runner_utils library in BUCK
187+
"misc/test_save_exported_model.py",
188+
# "misc/test_shared_qspecs.py", # needs executorch.backends.cortex_m.test.tester (no BUCK target)
189+
"misc/test_tosa_dialect_conv2d.py",
190+
"misc/test_tosa_dialect_dw_conv2d.py",
191+
"misc/test_tosa_dialect_shape_ops.py",
192+
"misc/test_tosa_spec.py",
60193
]
61194

62195
TESTS = {}
@@ -96,6 +229,7 @@ def define_arm_tests():
96229
"//executorch/backends/arm/tosa:partitioner",
97230
"//executorch/backends/arm:vgf",
98231
"//executorch/backends/test:graph_builder",
232+
"//executorch/backends/test/harness:tester",
99233
"//executorch/exir:lib",
100234
"fbsource//third-party/pypi/pytest:pytest",
101235
"fbsource//third-party/pypi/parameterized:parameterized",

0 commit comments

Comments
 (0)