Skip to content

Commit 63217d2

Browse files
authored
Arm backend: Do not skip _fuse_duplicate_users pass (#19017)
Removes previous workaround of skipping a pass for VGF backend, as the actual root cause (GRPHCOMP-3140) has been resolved. cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
1 parent 941486e commit 63217d2

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

backends/arm/test/misc/test_compile_spec.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55

66
import warnings
77

8-
from executorch.backends.arm.common.pipeline_config import SoftmaxDecompositionConfig
8+
from executorch.backends.arm.common.pipeline_config import (
9+
FuseDuplicateUsersConfig,
10+
SoftmaxDecompositionConfig,
11+
)
912
from executorch.backends.arm.ethosu import EthosUCompileSpec
1013
from executorch.backends.arm.tosa.compile_spec import TosaCompileSpec
1114
from executorch.backends.arm.vgf import VgfCompileSpec
@@ -63,6 +66,13 @@ def test_compile_spec_vgf_no_quant():
6366
EthosUCompileSpec._from_list(spec_list)
6467

6568

69+
def test_compile_spec_vgf_defaults_to_enabled_fuse_duplicate_users():
70+
compile_spec = VgfCompileSpec()
71+
pipeline_config = compile_spec._get_pass_pipeline_config()
72+
73+
assert pipeline_config.fuse_duplicate_users == FuseDuplicateUsersConfig.ENABLED
74+
75+
6676
def test_compile_spec_tosa_INT():
6777
compile_spec = TosaCompileSpec("TOSA-1.0+INT")
6878
spec_list = compile_spec._to_list()

backends/arm/vgf/compile_spec.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,3 @@ def _validate(self):
6666
def _get_output_format(cls) -> str:
6767
"""Return the artifact format emitted by this compile spec."""
6868
return "vgf"
69-
70-
def _create_default_pipeline_config(self) -> ArmPassPipelineConfig:
71-
config = super()._create_default_pipeline_config()
72-
# GRPHCOMP-3140 / MLETORCH-1529
73-
config.disable_fuse_duplicate_users()
74-
return config

0 commit comments

Comments
 (0)