Commit 6a25889
committed
Address review feedback on cortex-m run.sh wiring
Drops `--quantize` from .ci/scripts/test_cortex_m_e2e.sh — run.sh has no
such flag (only --no_quantize), so it was being silently swallowed; the
default behavior is to quantize, so the wrapper just needs to omit it.
Moves the dummy-input file creation back into run_fvp.sh so the script
is self-contained when given --bundle=. Previously run.sh created
fvp_dummy_input.bin next to the .bpte and run_fvp.sh asserted its
existence — a cross-script contract enforced only by ordering. With this
change run_fvp.sh creates the placeholder itself; future callers of
run_fvp.sh --bundle= no longer need to know about the requirement.
Adds a cortex-m branch to run.sh's check_setup() so a missing
arm-none-eabi-gcc toolchain surfaces immediately rather than deeper in
the build_test_runner.sh chain.
Adds a comment to run_fvp.sh's FVP-model selection noting that
cortex-m55 specifically maps to the SSE-300 FVP because it's the only
Cortex-M CPU on Corstone-300 today; cortex-m85 falls through to SSE-320.
Removes the now-redundant `backends/cortex_m/test/build_test_runner.sh`
step from the reusable cortex-m e2e workflow — run.sh invokes it
internally as part of the cortex-m target branch.
This change was authored with Claude (claude-opus-4-7[1m]).1 parent 087e6c7 commit 6a25889
4 files changed
Lines changed: 12 additions & 14 deletions
File tree
- .ci/scripts
- .github/workflows
- backends/arm/scripts
- examples/arm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | | - | |
24 | 25 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 46 | + | |
50 | 47 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| |||
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
226 | 230 | | |
227 | 231 | | |
228 | 232 | | |
| |||
364 | 368 | | |
365 | 369 | | |
366 | 370 | | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
| |||
0 commit comments