Address Copilot and lint review feedback

- Use Error log level for all failure paths instead of Info
- Replace ET_CHECK with graceful error log + return for get_outputs
- Use Python3_EXECUTABLE instead of hardcoded python in CMake
- Add RESULT_VARIABLE/ERROR_VARIABLE checks for gen_oplist.py
- Fix grammar in CMake status message
- Apply lint formatting suggestions

Author: psiddh

zephyr/samples/mv2-ethosu/CMakeLists.txt

@@ -47,14 +47,30 @@ set(ET_PTE_FILE_PATH
           FORCE
 )
 
+find_package(
+  Python3
+  COMPONENTS Interpreter
+  REQUIRED
+)
+
 execute_process(
   COMMAND
-    python "${CMAKE_CURRENT_LIST_DIR}/../../../codegen/tools/gen_oplist.py"
+    ${Python3_EXECUTABLE}
+    "${CMAKE_CURRENT_LIST_DIR}/../../../codegen/tools/gen_oplist.py"
     --model_file_path=${ET_PTE_FILE_PATH}
     --output_path=${CMAKE_CURRENT_BINARY_DIR}/temp.yaml
+  RESULT_VARIABLE GEN_OPLIST_RESULT
   OUTPUT_VARIABLE CMD_RESULT
+  ERROR_VARIABLE GEN_OPLIST_ERROR
 )
 
+if(NOT GEN_OPLIST_RESULT EQUAL 0)
+  message(
+    FATAL_ERROR
+      "gen_oplist.py failed with exit code ${GEN_OPLIST_RESULT}: ${GEN_OPLIST_ERROR}"
+  )
+endif()
+
 if(CMD_RESULT MATCHES "aten::" OR CMD_RESULT MATCHES "dim_order_ops::")
   set(FOUND_OPS_IN_FILE "true")
 else()
@@ -76,19 +92,13 @@ else()
   set(EXECUTORCH_SELECT_OPS_MODEL "")
   set(_EXECUTORCH_GEN_ZEPHYR_PORTABLE_OPS OFF)
   message(
-    "gen_oplist: No non delegated ops was found in ${ET_PTE_FILE_PATH} no ops added to build"
+    "gen_oplist: No non-delegated ops were found in ${ET_PTE_FILE_PATH}; no ops added to build"
   )
 endif()
 
 find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
 project(executorch_mv2_ethosu)
 
-find_package(
-  Python3
-  COMPONENTS Interpreter
-  REQUIRED
-)
-
 set(CMAKE_CXX_FLAGS
     "${CMAKE_CXX_FLAGS} -Wall -Wno-switch -Wno-float-conversion -Wno-double-promotion -ffunction-sections -fdata-sections"
 )

zephyr/samples/mv2-ethosu/src/main.cpp

@@ -284,7 +284,7 @@ int main(void) {
   Result<Program> program = Program::load(&loader);
   if (!program.ok()) {
     ET_LOG(
-        Info,
+        Error,
         "Program loading failed @ 0x%p: 0x%" PRIx32,
         program_data,
         static_cast<uint32_t>(program.error()));
@@ -307,7 +307,7 @@ int main(void) {
   Result<MethodMeta> method_meta = program->method_meta(method_name);
   if (!method_meta.ok()) {
     ET_LOG(
-        Info,
+        Error,
         "Failed to get method_meta for %s: 0x%x",
         method_name,
         (unsigned int)method_meta.error());
@@ -362,7 +362,7 @@ int main(void) {
 
   if (!method.ok()) {
     ET_LOG(
-        Info,
+        Error,
         "Loading of method %s failed with status 0x%" PRIx32,
         method_name,
         static_cast<uint32_t>(method.error()));
@@ -381,7 +381,7 @@ int main(void) {
 
     if (!prepared_inputs.ok()) {
       ET_LOG(
-          Info,
+          Error,
           "Preparing input failed: 0x%" PRIx32,
           static_cast<uint32_t>(prepared_inputs.error()));
       return 1;
@@ -397,27 +397,24 @@ int main(void) {
   uint32_t inference_time = end_time - start_time;
 
   if (status != Error::Ok) {
-    ET_LOG(
-        Info,
-        "Execution failed: 0x%" PRIx32,
-        static_cast<uint32_t>(status));
+    ET_LOG(Error, "Execution failed: 0x%" PRIx32, static_cast<uint32_t>(status));
     return 1;
   }
   ET_LOG(Info, "Inference completed in %u ms", inference_time);
 
   std::vector<EValue> outputs(method->outputs_size());
   status = method->get_outputs(outputs.data(), outputs.size());
-  ET_CHECK(status == Error::Ok);
+  if (status != Error::Ok) {
+    ET_LOG(Error, "get_outputs failed: 0x%" PRIx32, static_cast<uint32_t>(status));
+    return 1;
+  }
 
   ET_LOG(Info, "\n--- Classification Results ---");
   print_top_k(outputs);
 
   ET_LOG(Info, "\n========================================");
   ET_LOG(Info, "MobileNetV2 Demo Complete");
-  ET_LOG(
-      Info,
-      "Model size: %lu bytes",
-      static_cast<unsigned long>(pte_size));
+  ET_LOG(Info, "Model size: %lu bytes", static_cast<unsigned long>(pte_size));
   ET_LOG(
       Info,
       "Input: 224x224x3 RGB image (%lu bytes)",