You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Convert unconditional GTEST_SKIP tests to DISABLED_ prefix (#19355)
Summary:
A number of kernel unit tests are skipped unconditionally, with the very
first statement is `GTEST_SKIP() << "Dynamic shape not supported";`.
These tests therefore emit a `SKIPPED` result on every invocation while
the feature is
unimplemented.
The googletest recommended idiom for this case is the `DISABLED_` name
prefix:
- The test is still **compiled**, so the documenting body cannot rot.
- The test is **not executed** by gtest at all (no result is emitted).
This commit applies that conversion mechanically to every
unconditionally-skipped GTest in the ExecuTorch tree.
Disabled tests can still be opted into on demand via gtest's
`--gtest_also_run_disabled_tests` flag.
Differential Revision: D104126199
0 commit comments