Commit af69d08
authored
Use torch.median for error stats (#16683)
### Summary
This is a re-land of #16673
with updated test data. Previously, the error stats logic would throw
when a large tensor is passed in due to size limitations of
torch.quantile. The above PR switched it to use torch.median, but this
has differing behavior for tensors with an even number of elements.
Quantile will return the mean of the two medians, but torch.median takes
the lower. Either is fine for this use case - we just need to update the
test logic accordingly. I verified that the error stats unit tests pass
with this change.1 parent af9ce0b commit af69d08
2 files changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
47 | | - | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
55 | | - | |
| 57 | + | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| |||
0 commit comments