Commit eb851a5
authored
Fix Windows CUDA build: guard extension_cuda compile options to CXX (#20184)
Guard extension_cuda's ${_common_compile_options} with $<COMPILE_LANGUAGE:CXX> so the MSVC /wd4996 flag no longer leaks (via slimtensor INTERFACE, added in #20158) into the aoti_cuda_shims .cu nvcc compile, which failed with 'nvcc fatal: A single input file is required'. Also run the cuda-windows workflow on extension/cuda changes. Verified: Windows CUDA e2e 5/6 green (was 0/6).1 parent a1649b9 commit eb851a5
2 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
150 | 152 | | |
151 | 153 | | |
152 | 154 | | |
| 155 | + | |
153 | 156 | | |
154 | 157 | | |
155 | 158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
0 commit comments