Commit f116133
migrate is_fbcode-flagged TARGETS files to BUCK with runtime detection (#20404)
Summary:
Pull Request resolved: #20404
Chunk 2 of fbcode/executorch TARGETS->BUCK migration. 5 directories where
TARGETS called `define_common_targets(is_fbcode = True)` and the sister
BUCK called `define_common_targets()`. The shared targets.bzl actually
branches on is_fbcode, so the flag must be preserved.
Replaces the BUCK call with `define_common_targets(is_fbcode = is_fbcode())`
using `fbsource_utils.is_fbcode()` for runtime cell detection, then deletes
TARGETS. fbcode falls through to BUCK and gets the True branch as before;
xplat keeps getting the False branch.
Directories migrated:
- backends/vulkan/test/custom_ops
- backends/vulkan/test/op_tests
- codegen/tools
- extension/runner_util/test
- kernels/optimized
Reviewed By: mzlee
Differential Revision: D1090820611 parent 8c0f668 commit f116133
10 files changed
Lines changed: 15 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
| 9 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
| 9 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
| 9 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
| 9 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
| 9 | + | |
This file was deleted.
0 commit comments