Skip to content

Commit f116133

Browse files
bigfootjonmeta-codesync[bot]
authored andcommitted
migrate is_fbcode-flagged TARGETS files to BUCK with runtime detection (#20404)
Summary: Pull Request resolved: #20404 Chunk 2 of fbcode/executorch TARGETS->BUCK migration. 5 directories where TARGETS called `define_common_targets(is_fbcode = True)` and the sister BUCK called `define_common_targets()`. The shared targets.bzl actually branches on is_fbcode, so the flag must be preserved. Replaces the BUCK call with `define_common_targets(is_fbcode = is_fbcode())` using `fbsource_utils.is_fbcode()` for runtime cell detection, then deletes TARGETS. fbcode falls through to BUCK and gets the True branch as before; xplat keeps getting the False branch. Directories migrated: - backends/vulkan/test/custom_ops - backends/vulkan/test/op_tests - codegen/tools - extension/runner_util/test - kernels/optimized Reviewed By: mzlee Differential Revision: D109082061
1 parent 8c0f668 commit f116133

10 files changed

Lines changed: 15 additions & 41 deletions

File tree

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl.
33

4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
45
load(":targets.bzl", "define_common_targets")
56

67
oncall("executorch")
78

8-
define_common_targets()
9+
define_common_targets(is_fbcode = is_fbcode())

backends/vulkan/test/custom_ops/TARGETS

Lines changed: 0 additions & 5 deletions
This file was deleted.

backends/vulkan/test/op_tests/BUCK

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl.
33

4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
45
load(":targets.bzl", "define_common_targets")
56

67
oncall("executorch")
78

8-
define_common_targets()
9+
define_common_targets(is_fbcode = is_fbcode())

backends/vulkan/test/op_tests/TARGETS

Lines changed: 0 additions & 5 deletions
This file was deleted.

codegen/tools/BUCK

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl.
33

4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
45
load(":targets.bzl", "define_common_targets")
56

67
oncall("executorch")
78

8-
define_common_targets()
9+
define_common_targets(is_fbcode = is_fbcode())

codegen/tools/TARGETS

Lines changed: 0 additions & 5 deletions
This file was deleted.

extension/runner_util/test/BUCK

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl.
33

4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
45
load(":targets.bzl", "define_common_targets")
56

67
oncall("executorch")
78

8-
define_common_targets()
9+
define_common_targets(is_fbcode = is_fbcode())

extension/runner_util/test/TARGETS

Lines changed: 0 additions & 8 deletions
This file was deleted.

kernels/optimized/BUCK

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl.
33

4+
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
45
load(":targets.bzl", "define_common_targets")
56

67
oncall("executorch")
78

8-
define_common_targets()
9+
define_common_targets(is_fbcode = is_fbcode())

kernels/optimized/TARGETS

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)