migrate etrecord test from exir.capture to torch.export#13148
Merged
facebook-github-bot merged 1 commit intogh/gasoonjia/36/basefrom Aug 6, 2025
Merged
migrate etrecord test from exir.capture to torch.export#13148facebook-github-bot merged 1 commit intogh/gasoonjia/36/basefrom
facebook-github-bot merged 1 commit intogh/gasoonjia/36/basefrom
Conversation
Currently etrecord tests are heavily depending on exir.capture, our old and deprecated export flow, which means our test can not figure out the issue happened in main stream export flow. This diff migrates the export flow into torch.export. Differential Revision: [D79705852](https://our.internmc.facebook.com/intern/diff/D79705852/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13148
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit 3d2139f with merge base 981119e ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Gasoonjia
added a commit
that referenced
this pull request
Aug 6, 2025
Currently etrecord tests are heavily depending on exir.capture, our old and deprecated export flow, which means our test can not figure out the issue happened in main stream export flow. This diff migrates the export flow into torch.export. Differential Revision: [D79705852](https://our.internmc.facebook.com/intern/diff/D79705852/) ghstack-source-id: 301045643 Pull Request resolved: #13148
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79705852 |
This was referenced Aug 6, 2025
Gasoonjia
added
the
release notes: devtools
angelayi
approved these changes
Aug 6, 2025
facebook-github-bot
merged commit 92b44b9
into
gh/gasoonjia/36/base
102 of 107 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79705852 |
Gasoonjia
added a commit
that referenced
this pull request
Aug 6, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #13148 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/orig @diff-train-skip-merge Differential Revision: D79705852 Co-authored-by: gasoonjia <gasoonjia@icloud.com>
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#13148 by @Gasoonjia ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/34/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/36/orig @diff-train-skip-merge Differential Revision: D79705852 Co-authored-by: gasoonjia <gasoonjia@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently etrecord tests are heavily depending on exir.capture, our old and deprecated export flow, which means our test can not figure out the issue happened in main stream export flow. This diff migrates the export flow into torch.export.
Differential Revision: D79705852