Skip to content

Arm backend: Add 16A8W support and test for mul operation#13785

Closed
Ninja91 wants to merge 1 commit intogh/Ninja91/4/basefrom
gh/Ninja91/4/head
Closed

Arm backend: Add 16A8W support and test for mul operation#13785
Ninja91 wants to merge 1 commit intogh/Ninja91/4/basefrom
gh/Ninja91/4/head

Conversation

@Ninja91
Copy link
Copy Markdown
Contributor

@Ninja91 Ninja91 commented Aug 29, 2025

Stack from ghstack (oldest at bottom):

  • (to be filled)

Add 16A8W quantization support and test for the mul operation in ExecutorTorch ARM backend.

This follows the pattern established for linear operations, extending int16 support to mul operations.

Changes:

  • Add INT16 dtype validation support in op_mul.py
  • Add test_mul_tensor_16a8w_tosa_INT test function
  • Enable test_mul.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: D80510628

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Add 16A8W quantization support and test for the mul operation in ExecutorTorch ARM backend.

This follows the pattern established for linear operations, extending int16 support to mul operations.

Changes:
- Add INT16 dtype validation support in op_mul.py
- Add test_mul_tensor_16a8w_tosa_INT test function
- Enable test_mul.py in test targets configuration

The 16A8W configuration uses 16-bit activations with 8-bit weights, enabling higher precision for activations while maintaining weight efficiency.

Differential Revision: [D80510628](https://our.internmc.facebook.com/intern/diff/D80510628/)

[ghstack-poisoned]
@Ninja91 Ninja91 requested a review from digantdesai as a code owner August 29, 2025 02:06
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13785

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 11571f9 with merge base 9053089 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2025
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Nov 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2026

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@Sebastian-Larsson Sebastian-Larsson added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Feb 11, 2026
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Feb 11, 2026

Is this still needed?

@zingo zingo changed the title Add 16A8W support and test for mul operation Arm backend: Add 16A8W support and test for mul operation Feb 11, 2026
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Mar 10, 2026

We think this is done and can be closed, please reopen of you don't agree.

@zingo zingo closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm Stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants