Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16303
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 913c77e with merge base 43a32eb ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the QNN (Qualcomm Neural Network) Android AAR build by correcting the library path and fixing the QNN Runner constructor call.
- Updates QNN shared library path to match new CMake output directory structure
- Fixes QNN Runner instantiation by adding missing constructor parameter and adjusting variable scope
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/build_android_library.sh |
Updates the QNN library copy path to reflect the new CMake output structure with executorch/backends/qualcomm/ subdirectory |
extension/android/jni/jni_layer_llama.cpp |
Moves data_files_vector declaration to broader scope and adds missing performance_output_path parameter to QNN Runner constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Test plan
CI