Skip to content

Introduce MultimethodLoraConfig#17230

Merged
meta-codesync[bot] merged 6 commits intogh/lucylq/133/basefrom
gh/lucylq/133/head
Feb 13, 2026
Merged

Introduce MultimethodLoraConfig#17230
meta-codesync[bot] merged 6 commits intogh/lucylq/133/basefrom
gh/lucylq/133/head

Conversation

@lucylq
Copy link
Copy Markdown
Contributor

@lucylq lucylq commented Feb 5, 2026

Differential Revision: [D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17230

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 8 Pending

As of commit e619591 with merge base aa2f683 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq changed the title Introduce MultimethodLoraConfig [wip] Introduce MultimethodLoraConfig Feb 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces MultimethodLoraConfig, a new configuration class that enables exporting multiple methods (e.g., base model and LoRA variants) to a single .pte file. This is part of a larger stack adding multimethod support to the LLM export pipeline.

Changes:

  • Added Dict to typing imports to support the new configuration structure
  • Introduced MultimethodLoraConfig class with a dictionary mapping method names to optional LoRA configurations
  • Integrated MultimethodLoraConfig as a new field in the LlmConfig class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucylq lucylq changed the title [wip] Introduce MultimethodLoraConfig Introduce MultimethodLoraConfig Feb 10, 2026
@meta-codesync meta-codesync Bot merged commit 470fce2 into gh/lucylq/133/base Feb 13, 2026
181 of 182 checks passed
@meta-codesync meta-codesync Bot deleted the gh/lucylq/133/head branch February 13, 2026 20:11
lucylq added a commit that referenced this pull request Feb 13, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #17230 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/132/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/orig
Differential Revision:
[D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/)
@diff-train-skip-merge

---------

Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: lucylq <lfq@meta.com>
chizkiyahu pushed a commit to chizkiyahu/executorch that referenced this pull request Feb 23, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#17230 by
@lucylq
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/lucylq/132/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/lucylq/133/orig
Differential Revision:
[D92315627](https://our.internmc.facebook.com/intern/diff/D92315627/)
@diff-train-skip-merge

---------

Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: lucylq <lfq@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants