-
Notifications
You must be signed in to change notification settings - Fork 1k
exir: add flatbuffer Program serialization for performance #17333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JacobSzwejbka
merged 12 commits into
pytorch:main
from
chizkiyahu:exir-flatbuffer-serialize-fastpath_v2
Mar 6, 2026
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e8f3c73
exir: add flatbuffer Program serialization for performance
chizkiyahu e5db97a
CI FIX: fix validate_flatbuffer_gen.yml script
chizkiyahu d5ab9b9
fix flatc gen files
chizkiyahu 372c2ae
PR small fix
chizkiyahu 9a953d2
PR clean
chizkiyahu 3039600
PR fix BUCK file
chizkiyahu 1dc55fe
PR: fallback remove + comments
chizkiyahu e28f0c5
Merge branch 'main' into exir-flatbuffer-serialize-fastpath_v2
JacobSzwejbka bce3db3
exir: resolve conflict in exir/_serialize/test/BUCK
chizkiyahu c82f1ab
exir: merge main into exir-flatbuffer-serialize-fastpath_v2
chizkiyahu 2766d9a
Merge branch 'main' into exir-flatbuffer-serialize-fastpath_v2
JacobSzwejbka b313378
Merge branch 'main' into exir-flatbuffer-serialize-fastpath_v2
JacobSzwejbka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Validate Flatbuffer Generation | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| paths: | ||
| - "schema/**" | ||
| - "exir/_serialize/generated/executorch_flatbuffer/**" | ||
|
|
||
| jobs: | ||
| exir-flatbuffer: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: setup python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: install executorch (with flatc) | ||
| run: ./install_executorch.sh -e | ||
|
|
||
| - name: Generate flatbuffer Python | ||
| run: python exir/_serialize/generate_program.py | ||
|
|
||
| - name: Validate executorch_flatbuffer is unchanged | ||
| run: | | ||
| git add -A exir/_serialize/generated/executorch_flatbuffer | ||
| if ! git diff --cached --quiet -- exir/_serialize/generated/executorch_flatbuffer; then | ||
| echo "Error: executorch_flatbuffer has uncommitted changes." | ||
| echo "Please run 'python exir/_serialize/generate_program.py' to regenerate the files and commit the changes." | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.