-
Notifications
You must be signed in to change notification settings - Fork 1k
[devtools] Auto-record after-transform graph in ETRecord #17434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6e781ab
[devtools] Auto-record after-transform graph in ETRecord
Gasoonjia 97817c6
Update on "[devtools] Auto-record after-transform graph in ETRecord"
Gasoonjia 4fbd7ab
Update on "[devtools] Auto-record after-transform graph in ETRecord"
Gasoonjia 0165201
Update on "[devtools] Auto-record after-transform graph in ETRecord"
Gasoonjia 8dfb117
Update on "[devtools] Auto-record after-transform graph in ETRecord"
Gasoonjia 81b8520
Update on "[devtools] Auto-record after-transform graph in ETRecord"
Gasoonjia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious.
I am studying the logic of the graph_map naming:
executorch/devtools/etrecord/_etrecord.py
Line 651 in 43ee3f9
This hardcoded
forwardis appened because an edge_after_transform could possibly consist of multimethods?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes your are right. That's placeholder for multimethods supported.
Now we only support single forward name but in the future we will support multiple methods in the same program.