Skip to content

[ET-VK][qconv] Read weight buffer as int in pack_q8_conv2d_weights shader#17690

Closed
SS-JIA wants to merge 1 commit intogh/SS-JIA/443/basefrom
gh/SS-JIA/443/head
Closed

[ET-VK][qconv] Read weight buffer as int in pack_q8_conv2d_weights shader#17690
SS-JIA wants to merge 1 commit intogh/SS-JIA/443/basefrom
gh/SS-JIA/443/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Feb 25, 2026

Stack from ghstack (oldest at bottom):

The shader previously declared the input weight buffer as int8, requiring
the GL_EXT_shader_8bit_storage extension which is not supported on all
devices. Replace with an int (int32) buffer and extract individual bytes
via shift-and-mask, the same technique used in nchw_to_int8x4_buffer.glsl.
This makes the shader functional on devices without 8-bit buffer support.

Differential Revision: D94314255

…ader

The shader previously declared the input weight buffer as int8, requiring
the GL_EXT_shader_8bit_storage extension which is not supported on all
devices. Replace with an int (int32) buffer and extract individual bytes
via shift-and-mask, the same technique used in nchw_to_int8x4_buffer.glsl.
This makes the shader functional on devices without 8-bit buffer support.

Differential Revision: [D94314255](https://our.internmc.facebook.com/intern/diff/D94314255/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 25, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17690

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job

As of commit eca2a0d with merge base 63f9724 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant