[ET-VK][qconv] Read weight buffer as int in pack_q8_conv2d_weights shader#17690
Closed
SS-JIA wants to merge 1 commit intogh/SS-JIA/443/basefrom
Closed
[ET-VK][qconv] Read weight buffer as int in pack_q8_conv2d_weights shader#17690SS-JIA wants to merge 1 commit intogh/SS-JIA/443/basefrom
SS-JIA wants to merge 1 commit intogh/SS-JIA/443/basefrom
Conversation
…ader The shader previously declared the input weight buffer as int8, requiring the GL_EXT_shader_8bit_storage extension which is not supported on all devices. Replace with an int (int32) buffer and extract individual bytes via shift-and-mask, the same technique used in nchw_to_int8x4_buffer.glsl. This makes the shader functional on devices without 8-bit buffer support. Differential Revision: [D94314255](https://our.internmc.facebook.com/intern/diff/D94314255/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17690
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Cancelled JobAs of commit eca2a0d with merge base 63f9724 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 25, 2026
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The shader previously declared the input weight buffer as int8, requiring
the GL_EXT_shader_8bit_storage extension which is not supported on all
devices. Replace with an int (int32) buffer and extract individual bytes
via shift-and-mask, the same technique used in nchw_to_int8x4_buffer.glsl.
This makes the shader functional on devices without 8-bit buffer support.
Differential Revision: D94314255