Skip to content

MLX delegate (part 1)#17803

Merged
metascroy merged 13 commits intomainfrom
mlx-delegate-part1
Apr 7, 2026
Merged

MLX delegate (part 1)#17803
metascroy merged 13 commits intomainfrom
mlx-delegate-part1

Conversation

@metascroy
Copy link
Copy Markdown
Contributor

Takes changes from #16718, but strips all ops (except addmm) and examples.

Part2 will add back ops, and part 3 will add back examples.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 3, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17803

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 9 Pending, 3 Unrelated Failures

As of commit 9fe0a67 with merge base e0e10cc (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Mar 3, 2026

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D94997043.

@metascroy metascroy force-pushed the mlx-delegate-part1 branch from 540ad17 to 5ee8ac4 Compare March 5, 2026 05:38
Comment thread .github/workflows/mlx.yml Fixed
Comment thread .github/workflows/mlx.yml Fixed
Comment thread backends/mlx/README.md
@@ -0,0 +1,538 @@
# MLX Delegate for ExecuTorch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note saying this is an experimental backend

@manuelcandales
Copy link
Copy Markdown
Contributor

rebase to fix merge conflicts, and make sure CI is green

Copy link
Copy Markdown
Contributor

@manuelcandales manuelcandales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping, let's make sure this doesn't go stale.

Copy link
Copy Markdown
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Manual said about experimental in the README.md. Thanks Scott.

@metascroy metascroy force-pushed the mlx-delegate-part1 branch from 0adbe8c to 72a87fd Compare April 7, 2026 00:44
@metascroy metascroy merged commit 38c5ca3 into main Apr 7, 2026
420 of 433 checks passed
@metascroy metascroy deleted the mlx-delegate-part1 branch April 7, 2026 18:29
jpiat added a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
Takes changes from pytorch#16718, but
strips all ops (except addmm) and examples.

Part2 will add back ops, and part 3 will add back examples.
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
Takes changes from pytorch#16718, but
strips all ops (except addmm) and examples.

Part2 will add back ops, and part 3 will add back examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants