Skip to content

Arm backend: Add TOSA PAD dialect op#17940

Merged
oscarandersson8218 merged 5 commits intopytorch:mainfrom
oscarandersson8218:tosa_dialect_pad
Mar 10, 2026
Merged

Arm backend: Add TOSA PAD dialect op#17940
oscarandersson8218 merged 5 commits intopytorch:mainfrom
oscarandersson8218:tosa_dialect_pad

Conversation

@oscarandersson8218
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 commented Mar 5, 2026

Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor is replaced by a simpler node vistior for tosa.PAD.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are
replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor
is replaced by a simpler node vistior for tosa.pad.

Co-authored-by: Per Åstrand <per.astrand@arm.com>
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I9ddaa422d373f9a2a750429243ae39f8b8ffddf0
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17940

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 0245b20 with merge base 7824373 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 5, 2026
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Mar 6, 2026

Hi @SS-JIA this adds a file but I also spot srcs = glob(["op_*.py", "ops_*.py"]), so I think it should be fine.

@oscarandersson8218
Copy link
Copy Markdown
Collaborator Author

cortex_m_size_test failures are not introduced by this patch. Probably introduced by #17326.

Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok!

@oscarandersson8218 oscarandersson8218 merged commit 1fd211b into pytorch:main Mar 10, 2026
313 of 317 checks passed
jpiat pushed a commit to jpiat/executorch that referenced this pull request Mar 17, 2026
Adds new TOSA dialect op for PAD. aten.constant_pad_nd nodes are
replaced by tosa.PAD in RewritePadPass. op_constant_pad_nd node visitor
is replaced by a simpler node vistior for tosa.PAD.


cc @digantdesai @SS-JIA @freddan80 @per @zingo @mansnils
@Sebastian-Larsson @robell

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Co-authored-by: Per Åstrand <per.astrand@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants