Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17985
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Adjusts the ARM Cortex-M bare-metal size-test guardrail in CI to accommodate a recent binary size increase that started failing on trunk after #17326.
Changes:
- Bumps the
bare_metalsize-test threshold intest-arm-cortex-m-size-testfrom110642to111000.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [[ ${{ matrix.os}} == "bare_metal" ]]; then | ||
| toolchain_prefix=arm-none-eabi- | ||
| threshold="110642" # 108 KiB | ||
| threshold="111000" # 111 KiB |
There was a problem hiding this comment.
The numeric threshold value (111000) doesn’t correspond to the inline comment “111 KiB” (111 KiB would be 113664 bytes). Either adjust the comment to the correct unit/value (e.g., bytes or kB) or set the threshold to 111*1024 to match the comment, to avoid confusion when maintaining the size gate.
| threshold="111000" # 111 KiB | |
| threshold="111000" # 111000 bytes (~108 KiB) |
### Summary failing on trunk after pytorch#17326 ### Test plan ci
Summary
failing on trunk after #17326
Test plan
ci