Skip to content

[ET-VK] Generalize constant_pad_nd to support any storage type and packed dimension#18051

Merged
meta-codesync[bot] merged 8 commits intogh/SS-JIA/468/basefrom
gh/SS-JIA/468/head
Mar 18, 2026
Merged

[ET-VK] Generalize constant_pad_nd to support any storage type and packed dimension#18051
meta-codesync[bot] merged 8 commits intogh/SS-JIA/468/basefrom
gh/SS-JIA/468/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Mar 10, 2026

…cked dimension

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18051

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 11 Cancelled Jobs, 1 Unrelated Failure

As of commit 9b6a027 with merge base 22174fa (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ssjia added 3 commits March 11, 2026 09:52
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
ssjia added 2 commits March 17, 2026 11:27
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
…type and packed dimension"

Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)

[ghstack-poisoned]
@meta-codesync meta-codesync Bot merged commit 9ec6254 into gh/SS-JIA/468/base Mar 18, 2026
206 of 220 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/468/head branch March 18, 2026 01:46
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot March 18, 2026 01:46 Inactive
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and
texture). Migrate shaders to BufferMetadata/TextureMetadata with
indexing.glslh and unify dispatch into a single add_constant_pad_nd_node
function using DynamicDispatchNode.

Pull Request resolved: #18051
ghstack-source-id: 353546682
@exported-using-ghexport

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and
texture). Migrate shaders to BufferMetadata/TextureMetadata with
indexing.glslh and unify dispatch into a single add_constant_pad_nd_node
function using DynamicDispatchNode.

Pull Request resolved: #18051
ghstack-source-id: 353546682
@exported-using-ghexport

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and
texture). Migrate shaders to BufferMetadata/TextureMetadata with
indexing.glslh and unify dispatch into a single add_constant_pad_nd_node
function using DynamicDispatchNode.

Pull Request resolved: #18051
ghstack-source-id: 353546682
@exported-using-ghexport

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and
texture). Migrate shaders to BufferMetadata/TextureMetadata with
indexing.glslh and unify dispatch into a single add_constant_pad_nd_node
function using DynamicDispatchNode.

Pull Request resolved: #18051
ghstack-source-id: 353546682
@exported-using-ghexport

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and
texture). Migrate shaders to BufferMetadata/TextureMetadata with
indexing.glslh and unify dispatch into a single add_constant_pad_nd_node
function using DynamicDispatchNode.

Pull Request resolved: #18051
ghstack-source-id: 353546682
@exported-using-ghexport

Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants