[ET-VK] Generalize constant_pad_nd to support any storage type and packed dimension#18051
Merged
meta-codesync[bot] merged 8 commits intogh/SS-JIA/468/basefrom Mar 18, 2026
Merged
Conversation
…cked dimension Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
This PR needs a
|
This was referenced Mar 10, 2026
added 3 commits
March 11, 2026 09:52
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
andreanicastro
approved these changes
Mar 12, 2026
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
manuelcandales
approved these changes
Mar 17, 2026
added 2 commits
March 17, 2026 11:27
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
…type and packed dimension" Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities. Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/) [ghstack-poisoned]
9ec6254
into
gh/SS-JIA/468/base
206 of 220 checks passed
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and texture). Migrate shaders to BufferMetadata/TextureMetadata with indexing.glslh and unify dispatch into a single add_constant_pad_nd_node function using DynamicDispatchNode. Pull Request resolved: #18051 ghstack-source-id: 353546682 @exported-using-ghexport Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and texture). Migrate shaders to BufferMetadata/TextureMetadata with indexing.glslh and unify dispatch into a single add_constant_pad_nd_node function using DynamicDispatchNode. Pull Request resolved: #18051 ghstack-source-id: 353546682 @exported-using-ghexport Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and texture). Migrate shaders to BufferMetadata/TextureMetadata with indexing.glslh and unify dispatch into a single add_constant_pad_nd_node function using DynamicDispatchNode. Pull Request resolved: #18051 ghstack-source-id: 353546682 @exported-using-ghexport Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and texture). Migrate shaders to BufferMetadata/TextureMetadata with indexing.glslh and unify dispatch into a single add_constant_pad_nd_node function using DynamicDispatchNode. Pull Request resolved: #18051 ghstack-source-id: 353546682 @exported-using-ghexport Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize constant_pad_nd to support ANY_STORAGE (both buffer and texture). Migrate shaders to BufferMetadata/TextureMetadata with indexing.glslh and unify dispatch into a single add_constant_pad_nd_node function using DynamicDispatchNode. Pull Request resolved: #18051 ghstack-source-id: 353546682 @exported-using-ghexport Differential Revision: [D95970168](https://our.internmc.facebook.com/intern/diff/D95970168/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Replace the old pad_channel and pad_height_width shaders with generalized pad_buffer and pad_texture shaders that work with any storage type and packed dimension using BufferMetadata/TextureMetadata and indexing.glslh utilities.
Differential Revision: D95970168