[ET-VK] Add ANY_STORAGE support to expand_copy#18053
Merged
meta-codesync[bot] merged 8 commits intogh/SS-JIA/470/basefrom Mar 18, 2026
Merged
[ET-VK] Add ANY_STORAGE support to expand_copy#18053meta-codesync[bot] merged 8 commits intogh/SS-JIA/470/basefrom
meta-codesync[bot] merged 8 commits intogh/SS-JIA/470/basefrom
Conversation
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
This PR needs a
|
This was referenced Mar 10, 2026
added 4 commits
March 11, 2026 09:52
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
manuelcandales
approved these changes
Mar 17, 2026
added 2 commits
March 17, 2026 11:27
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic shape support. The texture shader maps each output texel coordinate to the corresponding input texel using modulo on the input sizes, matching the semantics of the existing buffer shader. Use meta_ubo() instead of buffer_meta_ubo() so the correct UBO type is selected based on storage type. Use extract_int_or_symint_list() for target sizes to handle symbolic integers. Register as ANY_STORAGE. Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/) [ghstack-poisoned]
53d8949
into
gh/SS-JIA/470/base
204 of 220 checks passed
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA
pushed a commit
that referenced
this pull request
Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant using BufferMetadata with indexing.glslh. Unify dispatch with add_storage_type_suffix and DynamicDispatchNode. Add resize function and symint support for dynamic target sizes. Pull Request resolved: #18053 ghstack-source-id: 353546690 @exported-using-ghexport Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.
Differential Revision: D95970162