Skip to content

[ET-VK] Add ANY_STORAGE support to expand_copy#18053

Merged
meta-codesync[bot] merged 8 commits intogh/SS-JIA/470/basefrom
gh/SS-JIA/470/head
Mar 18, 2026
Merged

[ET-VK] Add ANY_STORAGE support to expand_copy#18053
meta-codesync[bot] merged 8 commits intogh/SS-JIA/470/basefrom
gh/SS-JIA/470/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Mar 10, 2026

Stack from ghstack (oldest at bottom):

Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: D95970162

Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18053

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 11 Cancelled Jobs, 1 Unrelated Failure

As of commit eda7457 with merge base 22174fa (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ssjia added 4 commits March 11, 2026 09:52
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
ssjia added 2 commits March 17, 2026 11:27
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
Add a texture shader variant for expand_copy and a resize function for dynamic
shape support. The texture shader maps each output texel coordinate to the
corresponding input texel using modulo on the input sizes, matching the
semantics of the existing buffer shader. Use meta_ubo() instead of
buffer_meta_ubo() so the correct UBO type is selected based on storage type.
Use extract_int_or_symint_list() for target sizes to handle symbolic integers.
Register as ANY_STORAGE.

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)

[ghstack-poisoned]
@meta-codesync meta-codesync Bot merged commit 53d8949 into gh/SS-JIA/470/base Mar 18, 2026
204 of 220 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/470/head branch March 18, 2026 01:47
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot March 18, 2026 01:47 Inactive
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
SS-JIA pushed a commit that referenced this pull request Mar 18, 2026
Modernize expand_copy to support ANY_STORAGE. Add buffer shader variant
using BufferMetadata with indexing.glslh. Unify dispatch with
add_storage_type_suffix and DynamicDispatchNode. Add resize function and
symint support for dynamic target sizes.

Pull Request resolved: #18053
ghstack-source-id: 353546690
@exported-using-ghexport

Differential Revision: [D95970162](https://our.internmc.facebook.com/intern/diff/D95970162/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants