[ET-VK] Support alias_copy in partitioner by removing it as a redundant op#18408
Merged
meta-codesync[bot] merged 1 commit intogh/SS-JIA/501/basefrom Mar 24, 2026
Merged
[ET-VK] Support alias_copy in partitioner by removing it as a redundant op#18408meta-codesync[bot] merged 1 commit intogh/SS-JIA/501/basefrom
meta-codesync[bot] merged 1 commit intogh/SS-JIA/501/basefrom
Conversation
…nt op Models using QK normalization (e.g., Qwen3) generate aten.alias_copy.default nodes from RMSNorm. Without Vulkan support for this op, these nodes create partition boundaries that cause SpecViolationError during export. Since alias_copy is a no-op identity operation, the fix registers it in op_registry so the partitioner delegates it, and adds it to RemoveRedundantOpsTransform so preprocess removes it before serialization. The C++ runtime never needs to handle alias_copy. Differential Revision: [D97757921](https://our.internmc.facebook.com/intern/diff/D97757921/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18408
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6264407 with merge base 60d57e5 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
pushed a commit
that referenced
this pull request
Mar 23, 2026
…nt op Models using QK normalization (e.g., Qwen3) generate aten.alias_copy.default nodes from RMSNorm. Without Vulkan support for this op, these nodes create partition boundaries that cause SpecViolationError during export. Since alias_copy is a no-op identity operation, the fix registers it in op_registry so the partitioner delegates it, and adds it to RemoveRedundantOpsTransform so preprocess removes it before serialization. The C++ runtime never needs to handle alias_copy. Differential Revision: [D97757921](https://our.internmc.facebook.com/intern/diff/D97757921/) ghstack-source-id: 356136429 Pull Request resolved: #18408
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
manuelcandales
approved these changes
Mar 24, 2026
meta-codesync
Bot
merged commit 8955ecd
into
gh/SS-JIA/501/base
138 of 146 checks passed
SS-JIA
pushed a commit
that referenced
this pull request
Mar 24, 2026
…nt op (#18461) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #18408 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/500/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/orig Differential Revision: [D97757921](https://our.internmc.facebook.com/intern/diff/D97757921/) @diff-train-skip-merge Co-authored-by: ssjia <ssjia@devvm26340.ftw0.facebook.com>
SS-JIA
pushed a commit
that referenced
this pull request
Mar 24, 2026
…nt op (#18461) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #18408 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/500/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/501/orig Differential Revision: [D97757921](https://our.internmc.facebook.com/intern/diff/D97757921/) @diff-train-skip-merge Co-authored-by: ssjia <ssjia@devvm26340.ftw0.facebook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Models using QK normalization (e.g., Qwen3) generate aten.alias_copy.default
nodes from RMSNorm. Without Vulkan support for this op, these nodes create
partition boundaries that cause SpecViolationError during export. Since
alias_copy is a no-op identity operation, the fix registers it in op_registry
so the partitioner delegates it, and adds it to RemoveRedundantOpsTransform
so preprocess removes it before serialization. The C++ runtime never needs to
handle alias_copy.
Differential Revision: D97757921