Skip to content

Arm backend: Use TOSA-context when adding passes#18442

Merged
oscarandersson8218 merged 2 commits intopytorch:mainfrom
oscarandersson8218:pass_manager_tosa_context
Apr 16, 2026
Merged

Arm backend: Use TOSA-context when adding passes#18442
oscarandersson8218 merged 2 commits intopytorch:mainfrom
oscarandersson8218:pass_manager_tosa_context

Conversation

@oscarandersson8218
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 commented Mar 24, 2026

Make sure to be inside TosaLoweringContext when adding/initializing passes. This is needed as passes may try to set self.shape_env using get_context_shape_env(). This patch also uses _get_shape_env_from_gm instead of graph_module.shape_env as we cannot rely on the shape_env being set in the graph_module even though sym-ints are present in the graph.

cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18442

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Cancelled Jobs, 4 Unrelated Failures

As of commit 6c74b96 with merge base 87e65ac (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 24, 2026
@oscarandersson8218 oscarandersson8218 force-pushed the pass_manager_tosa_context branch from e5256e9 to 8adc31a Compare March 31, 2026 07:53
@oscarandersson8218 oscarandersson8218 force-pushed the pass_manager_tosa_context branch 2 times, most recently from 09a0c8f to d9c7808 Compare April 14, 2026 12:16
@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 14, 2026

@digantdesai / @GregoryComer this adds timeout to the global suite (not only Arm) so we assume you want to signoff on this :)

Make sure to be inside TosaLoweringContext when adding/initializing
passes. This is needed as passes may try to set self.shape_env using
get_context_shape_env(). This patch also uses _get_shape_env_from_gm
instead of graph_module.shape_env as we cannot rely on the shape_env
being set in the graph_module even though sym-ints are present in the
graph.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: If515e12af3382909320585d1a1064281203cbda9
Adds a per testcase timeout for tests in backends/test/suite. The
timeout is set to 1200s for models and 120s for ops.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Iebf0d520953a10b2e7934b7f3540a2e6a2806e38
@oscarandersson8218 oscarandersson8218 force-pushed the pass_manager_tosa_context branch from d9c7808 to 6c74b96 Compare April 15, 2026 06:20
@oscarandersson8218
Copy link
Copy Markdown
Collaborator Author

Unrelated failures.

@oscarandersson8218 oscarandersson8218 merged commit c567d58 into pytorch:main Apr 16, 2026
410 of 422 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants