Skip to content

Fix UB in to_string(Error) for unrecognized error codes (#18554) (#18554) #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Apr 9, 2026
Merged

Fix UB in to_string(Error) for unrecognized error codes (#18554) (#18554) #18554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runtime/core/error.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ constexpr const char* to_string(const Error error) {
case Error::RegistrationAlreadyRegistered:
return "Error::RegistrationAlreadyRegistered";
}
return "Error::Unknown";
}

} // namespace runtime
Expand Down
66 changes: 66 additions & 0 deletions runtime/core/test/error_handling_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,72 @@ class Movable {
mutable void* buffer_;
};

TEST(ErrorHandlingTest, ToStringKnownError) {
EXPECT_STREQ(executorch::runtime::to_string(Error::Ok), "Error::Ok");
EXPECT_STREQ(
executorch::runtime::to_string(Error::Internal), "Error::Internal");
EXPECT_STREQ(
executorch::runtime::to_string(Error::InvalidState),
"Error::InvalidState");
EXPECT_STREQ(
executorch::runtime::to_string(Error::EndOfMethod), "Error::EndOfMethod");
EXPECT_STREQ(
executorch::runtime::to_string(Error::AlreadyLoaded),
"Error::AlreadyLoaded");
EXPECT_STREQ(
executorch::runtime::to_string(Error::NotSupported),
"Error::NotSupported");
EXPECT_STREQ(
executorch::runtime::to_string(Error::NotImplemented),
"Error::NotImplemented");
EXPECT_STREQ(
executorch::runtime::to_string(Error::InvalidArgument),
"Error::InvalidArgument");
EXPECT_STREQ(
executorch::runtime::to_string(Error::InvalidType), "Error::InvalidType");
EXPECT_STREQ(
executorch::runtime::to_string(Error::OperatorMissing),
"Error::OperatorMissing");
EXPECT_STREQ(
executorch::runtime::to_string(Error::RegistrationExceedingMaxKernels),
"Error::RegistrationExceedingMaxKernels");
EXPECT_STREQ(
executorch::runtime::to_string(Error::RegistrationAlreadyRegistered),
"Error::RegistrationAlreadyRegistered");
EXPECT_STREQ(
executorch::runtime::to_string(Error::NotFound), "Error::NotFound");
EXPECT_STREQ(
executorch::runtime::to_string(Error::MemoryAllocationFailed),
"Error::MemoryAllocationFailed");
EXPECT_STREQ(
executorch::runtime::to_string(Error::AccessFailed),
"Error::AccessFailed");
EXPECT_STREQ(
executorch::runtime::to_string(Error::InvalidProgram),
"Error::InvalidProgram");
EXPECT_STREQ(
executorch::runtime::to_string(Error::InvalidExternalData),
"Error::InvalidExternalData");
EXPECT_STREQ(
executorch::runtime::to_string(Error::OutOfResources),
"Error::OutOfResources");
EXPECT_STREQ(
executorch::runtime::to_string(Error::DelegateInvalidCompatibility),
"Error::DelegateInvalidCompatibility");
EXPECT_STREQ(
executorch::runtime::to_string(Error::DelegateMemoryAllocationFailed),
"Error::DelegateMemoryAllocationFailed");
EXPECT_STREQ(
executorch::runtime::to_string(Error::DelegateInvalidHandle),
"Error::DelegateInvalidHandle");
}

TEST(ErrorHandlingTest, ToStringUnknownError) {
auto unknown = static_cast<Error>(0xFF);
const char* result = executorch::runtime::to_string(unknown);
EXPECT_STREQ(result, "Error::Unknown");
}

TEST(ErrorHandlingTest, ResultBasic) {
Result<uint32_t> r(1);
ASSERT_TRUE(r.ok());
Expand Down
Loading