Skip to content

Use unfused SDPA for short sequences (q_len <= 128 or kv_len <= 128)#18651

Open
kimishpatel wants to merge 22 commits into
gh/kimishpatel/224/basefrom
gh/kimishpatel/224/head
Open

Use unfused SDPA for short sequences (q_len <= 128 or kv_len <= 128)#18651
kimishpatel wants to merge 22 commits into
gh/kimishpatel/224/basefrom
gh/kimishpatel/224/head

Conversation

@pytorch-bot

pytorch-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18651

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 10 Unrelated Failures

As of commit 4474b91 with merge base 1debeb6 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2026

@digantdesai digantdesai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

kimishpatel added a commit that referenced this pull request Apr 6, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 363188578
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 7, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 363628066
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 8, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 364312869
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 9, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 364945033
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 13, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 366379776
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 13, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 366603543
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
kimishpatel added a commit that referenced this pull request Apr 14, 2026
Pull Request resolved: #18651

ATT
ghstack-source-id: 367028665
@exported-using-ghexport

Differential Revision: [D96044308](https://our.internmc.facebook.com/intern/diff/D96044308/)
@meta-cla

meta-cla Bot commented Jul 3, 2026

Copy link
Copy Markdown

Hi @kimishpatel!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants