Skip to content

Qualcomm AI Engine Direct - Adding QNN backend support for avg_pool_1d core ATen op#18733

Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:avg_pool1d
Apr 9, 2026
Merged

Qualcomm AI Engine Direct - Adding QNN backend support for avg_pool_1d core ATen op#18733
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:avg_pool1d

Conversation

@qti-horodnic
Copy link
Copy Markdown
Contributor

Summary

Adding support for the avg_pool_1d ATen op by a decomposition pass using avg_pool_2d and the flow:

avg_pool1d(N, C, L) 
  → unsqueeze(2) 
  → avg_pool2d(N, C, 1, L) with kernel (1, k)
  → squeeze(2)
  → output(N, C, L_out)

Refactored the existing logic to combine the logic from adaptive_avg_pool1d into a single annotation for both ops.

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_avg_pool1d --model SM8750 --host aisw-vm19-labsd --device b3bf37fe --build_folder build-android
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator.test_qnn_backend_avg_pool1d --model SM8750 --host aisw-vm19-labsd --device b3bf37fe --build_folder build-android

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNFloatingPointOperator.test_qnn_backend_adaptive_avg_pool1d --model SM8750 --host aisw-vm19-labsd --device b3bf37fe --build_folder build-android
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperator.test_qnn_backend_adaptive_avg_pool1d --model SM8750 --host aisw-vm19-labsd --device b3bf37fe --build_folder build-android

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18733

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit c57e55a with merge base c7f1d72 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@qti-horodnic
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot Bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@abhinaykukkadapu abhinaykukkadapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qti-horodnic thanks for adding the support.

@abhinaykukkadapu abhinaykukkadapu merged commit 137dedc into pytorch:main Apr 9, 2026
158 of 166 checks passed
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants