Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737
Upgrade fbcode/executorch to Python Scientific Stack 3 (#18737)#18737meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18737
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 651e4f4 with merge base 107eb92 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@robert-kalmar There are efforts within Meta to upgrade to new numpy versions; it seems that some changes in the NXP backend will be needed for this. Just want to check with you guys if the changes make sense. |
Summary: Pull Request resolved: pytorch#18737 Differential Revision: D99707657
Summary: Pull Request resolved: pytorch#18737 Differential Revision: D99707657
@SS-JIA, understand. The changes are legit. It is only Meta internal upgrade, or OSS ExecuTorch too? This PR contains just the update for the API used to NUMPY, but not the numpy version - https://github.com/pytorch/executorch/blob/main/pyproject.toml . Is the intention is allow both numpy 2.x and 3x or the update is just split into multiple PRs? FYI, such a PR was already opened by @rascani #16714 some time ago, but not merged. |
88bfcad to
e6832a7
Compare
Summary: Pull Request resolved: #18737 Differential Revision: D99707657
Summary: Pull Request resolved: pytorch#18737 Differential Revision: D99707657
e6832a7 to
a9dd9da
Compare
Summary: Pull Request resolved: pytorch#18737 Differential Revision: D99707657
a9dd9da to
651e4f4
Compare
Summary: Pull Request resolved: #18737
Differential Revision: D99707657