Fix execute permissions for flatc binary extracted from PAR files (#18738)#18738
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Apr 8, 2026
Merged
Fix execute permissions for flatc binary extracted from PAR files (#18738)#18738meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18738
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit 95462f4 with merge base 71db7c7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Apr 7, 2026
…torch#18738) Summary: When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Differential Revision: D99780508
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Apr 7, 2026
…torch#18738) Summary: When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Differential Revision: D99780508
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Apr 7, 2026
…torch#18738) Summary: Pull Request resolved: pytorch#18738 When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Differential Revision: D99780508
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Apr 7, 2026
…torch#18738) Summary: When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Reviewed By: abhinaykukkadapu Differential Revision: D99780508
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Apr 7, 2026
…torch#18738) Summary: Pull Request resolved: pytorch#18738 When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Reviewed By: abhinaykukkadapu Differential Revision: D99780508
…torch#18738) Summary: When binaries are extracted from PAR files via `importlib.resources.as_file()`, execute permissions are not preserved, causing PermissionError when trying to run them. This change ensures the flatc binary has execute permissions after extraction. Files fixed: - `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions Reviewed By: abhinaykukkadapu Differential Revision: D99780508
abhinaykukkadapu
approved these changes
Apr 7, 2026
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Apr 14, 2026
…torch#18738) Differential Revision: D99780508 Pull Request resolved: pytorch#18738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When binaries are extracted from PAR files via
importlib.resources.as_file(),execute permissions are not preserved, causing PermissionError when trying to
run them.
This change ensures the flatc binary has execute permissions after extraction.
Files fixed:
executorch/exir/_serialize/_flatbuffer.py:_run_flatc- ensure flatc binary has execute permissionsReviewed By: abhinaykukkadapu
Differential Revision: D99780508