Skip to content

Fix execute permissions for flatc binary extracted from PAR files (#18738)#18738

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
navsud:export-D99780508
Apr 8, 2026
Merged

Fix execute permissions for flatc binary extracted from PAR files (#18738)#18738
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
navsud:export-D99780508

Conversation

@navsud
Copy link
Copy Markdown
Contributor

@navsud navsud commented Apr 7, 2026

Summary:

When binaries are extracted from PAR files via importlib.resources.as_file(),
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:

  • executorch/exir/_serialize/_flatbuffer.py: _run_flatc - ensure flatc binary has execute permissions

Reviewed By: abhinaykukkadapu

Differential Revision: D99780508

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18738

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit 95462f4 with merge base 71db7c7 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 7, 2026

@navsud has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99780508.

@meta-codesync meta-codesync Bot changed the title Fix execute permissions for flatc binary extracted from PAR files Fix execute permissions for flatc binary extracted from PAR files (#18738) Apr 7, 2026
navsud added a commit to navsud/executorch that referenced this pull request Apr 7, 2026
…torch#18738)

Summary:

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Differential Revision: D99780508
@navsud navsud force-pushed the export-D99780508 branch from 8c27298 to 086d299 Compare April 7, 2026 16:39
navsud added a commit to navsud/executorch that referenced this pull request Apr 7, 2026
…torch#18738)

Summary:

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Differential Revision: D99780508
@navsud navsud force-pushed the export-D99780508 branch from 086d299 to ccc5ae8 Compare April 7, 2026 16:40
navsud added a commit to navsud/executorch that referenced this pull request Apr 7, 2026
…torch#18738)

Summary:
Pull Request resolved: pytorch#18738

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Differential Revision: D99780508
@navsud navsud force-pushed the export-D99780508 branch from ccc5ae8 to 94da117 Compare April 7, 2026 16:43
@navsud navsud added the release notes: none Do not include this in the release notes label Apr 7, 2026
@navsud navsud force-pushed the export-D99780508 branch from 94da117 to a8c9c56 Compare April 7, 2026 21:52
navsud added a commit to navsud/executorch that referenced this pull request Apr 7, 2026
…torch#18738)

Summary:

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Reviewed By: abhinaykukkadapu

Differential Revision: D99780508
navsud added a commit to navsud/executorch that referenced this pull request Apr 7, 2026
…torch#18738)

Summary:
Pull Request resolved: pytorch#18738

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Reviewed By: abhinaykukkadapu

Differential Revision: D99780508
@navsud navsud force-pushed the export-D99780508 branch from a8c9c56 to 6d7f001 Compare April 7, 2026 21:56
…torch#18738)

Summary:

When binaries are extracted from PAR files via `importlib.resources.as_file()`,
execute permissions are not preserved, causing PermissionError when trying to
run them.

This change ensures the flatc binary has execute permissions after extraction.

Files fixed:
- `executorch/exir/_serialize/_flatbuffer.py`: `_run_flatc` - ensure flatc binary has execute permissions

Reviewed By: abhinaykukkadapu

Differential Revision: D99780508
@navsud navsud force-pushed the export-D99780508 branch from 6d7f001 to 95462f4 Compare April 7, 2026 22:33
@meta-codesync meta-codesync Bot merged commit b5ae0b9 into pytorch:main Apr 8, 2026
160 of 165 checks passed
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants