Qualcomm AI Engine Direct - Adding QNN backend support for acos core ATen Op#18743
Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom Apr 7, 2026
Merged
Qualcomm AI Engine Direct - Adding QNN backend support for acos core ATen Op#18743abhinaykukkadapu merged 1 commit intopytorch:mainfrom
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18743
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 131 PendingAs of commit 8fc5595 with merge base fcccda3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "release notes: qualcomm" |
abhinaykukkadapu
approved these changes
Apr 7, 2026
Contributor
|
Thanks for adding the support. |
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for the acos ATen op by a decomposition pass using the identity:
acos(x) = π/2 - asin(x)Also fixed a small bug in
decompose_log_variantscaused by callingget_const_nodemultiple times in a loop with the sameattr_name, creating multiple constant nodes redundantly which point to the same buffer. Added a unit test for that scenario as well.Test plan
For the
decompose_log_variantsbug fix: