Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18747
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 0620178 with merge base 19f7ff2 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Adjusts Program::load() verification behavior to avoid failing CI/tests when Verification::InternalConsistency is requested but program verification is compiled out (e.g., Release builds), by gracefully falling back to minimal verification.
Changes:
- Replaces the hard error on
InternalConsistencyrequests whenET_ENABLE_PROGRAM_VERIFICATIONis disabled with an informational log and fallback behavior. - Ensures the minimal root-table-offset bounds check also runs for
InternalConsistencyrequests when full verification isn’t available.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #endif | ||
| ) { | ||
| // Verify that the root table offset is within bounds. | ||
| // In InternalConsistency mode this is done by VerifyProgramBuffer above. |
There was a problem hiding this comment.
The comment about InternalConsistency here is now misleading in builds where ET_ENABLE_PROGRAM_VERIFICATION is disabled: in that configuration an InternalConsistency request falls back and VerifyProgramBuffer is not called above. Consider rewording to clarify that the root-offset check is redundant only when InternalConsistency verification is actually available/enabled.
| // In InternalConsistency mode this is done by VerifyProgramBuffer above. | |
| // This check is also covered by VerifyProgramBuffer when full | |
| // InternalConsistency verification is enabled and runs above. |
|
Looks good, thanks for fixing it fast. |
### Summary The problem is: 1. In tests, Verification::InternalConsistency is requested. 2. In release builds, ET_ENABLE_PROGRAM_VERIFICATION=False. 3. pytorch#18597 returned a hard error when Verification::InternalConsistency was requested but not available (ie when 1 and 2 conflict) This PR reverts the hard error and falls back to Verification::Minimal when Verification::InternalConsistency is required but not available (e.g. in Release builds) ### Test plan CI
Summary
The problem is:
This PR reverts the hard error and falls back to Verification::Minimal when Verification::InternalConsistency is required but not available (e.g. in Release builds)
Test plan
CI