Skip to content

Fix trunk ci#18747

Merged
lucylq merged 1 commit intomainfrom
lfq.ci-fix
Apr 8, 2026
Merged

Fix trunk ci#18747
lucylq merged 1 commit intomainfrom
lfq.ci-fix

Conversation

@lucylq
Copy link
Copy Markdown
Contributor

@lucylq lucylq commented Apr 7, 2026

Summary

The problem is:

  1. In tests, Verification::InternalConsistency is requested.
  2. In release builds, ET_ENABLE_PROGRAM_VERIFICATION=False.
  3. Check flatbuffer offset when verification is minimal #18597 returned a hard error when Verification::InternalConsistency was requested but not available (ie when 1 and 2 conflict)

This PR reverts the hard error and falls back to Verification::Minimal when Verification::InternalConsistency is required but not available (e.g. in Release builds)

Test plan

CI

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 0620178 with merge base 19f7ff2 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq lucylq requested a review from abhinaykukkadapu April 7, 2026 20:39
@lucylq lucylq marked this pull request as ready for review April 7, 2026 20:39
Copilot AI review requested due to automatic review settings April 7, 2026 20:39
@lucylq lucylq requested a review from JacobSzwejbka as a code owner April 7, 2026 20:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Program::load() verification behavior to avoid failing CI/tests when Verification::InternalConsistency is requested but program verification is compiled out (e.g., Release builds), by gracefully falling back to minimal verification.

Changes:

  • Replaces the hard error on InternalConsistency requests when ET_ENABLE_PROGRAM_VERIFICATION is disabled with an informational log and fallback behavior.
  • Ensures the minimal root-table-offset bounds check also runs for InternalConsistency requests when full verification isn’t available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#endif
) {
// Verify that the root table offset is within bounds.
// In InternalConsistency mode this is done by VerifyProgramBuffer above.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about InternalConsistency here is now misleading in builds where ET_ENABLE_PROGRAM_VERIFICATION is disabled: in that configuration an InternalConsistency request falls back and VerifyProgramBuffer is not called above. Consider rewording to clarify that the root-offset check is redundant only when InternalConsistency verification is actually available/enabled.

Suggested change
// In InternalConsistency mode this is done by VerifyProgramBuffer above.
// This check is also covered by VerifyProgramBuffer when full
// InternalConsistency verification is enabled and runs above.

Copilot uses AI. Check for mistakes.
@abhinaykukkadapu
Copy link
Copy Markdown
Contributor

Looks good, thanks for fixing it fast.

@lucylq lucylq merged commit ccf8913 into main Apr 8, 2026
427 of 442 checks passed
@lucylq lucylq deleted the lfq.ci-fix branch April 8, 2026 00:38
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
### Summary
The problem is:

1. In tests, Verification::InternalConsistency is requested.
2. In release builds, ET_ENABLE_PROGRAM_VERIFICATION=False. 
3. pytorch#18597 returned a hard
error when Verification::InternalConsistency was requested but not
available (ie when 1 and 2 conflict)

This PR reverts the hard error and falls back to Verification::Minimal
when Verification::InternalConsistency is required but not available
(e.g. in Release builds)

### Test plan
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants