Skip to content

[ET-VK] Deduplicate transition clone nodes in TagMemoryMetaPass#18771

Merged
meta-codesync[bot] merged 2 commits intogh/SS-JIA/517/basefrom
gh/SS-JIA/517/head
Apr 8, 2026
Merged

[ET-VK] Deduplicate transition clone nodes in TagMemoryMetaPass#18771
meta-codesync[bot] merged 2 commits intogh/SS-JIA/517/basefrom
gh/SS-JIA/517/head

Conversation

@SS-JIA
Copy link
Copy Markdown
Contributor

@SS-JIA SS-JIA commented Apr 8, 2026

Stack from ghstack (oldest at bottom):

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.

Differential Revision: D100004700

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.

Differential Revision: [D100004700](https://our.internmc.facebook.com/intern/diff/D100004700/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18771

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 3 Unrelated Failures

As of commit 1710eed with merge base 4afd7f9 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…aPass"

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.

Differential Revision: [D100004700](https://our.internmc.facebook.com/intern/diff/D100004700/)

[ghstack-poisoned]
@meta-codesync meta-codesync Bot merged commit 5221944 into gh/SS-JIA/517/base Apr 8, 2026
159 of 164 checks passed
@meta-codesync meta-codesync Bot deleted the gh/SS-JIA/517/head branch April 8, 2026 20:57
@meta-codesync meta-codesync Bot temporarily deployed to cherry-pick-bot April 8, 2026 20:57 Inactive
SS-JIA pushed a commit that referenced this pull request Apr 8, 2026
Pull Request resolved: #18771

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.
ghstack-source-id: 364280900
@exported-using-ghexport

Differential Revision: [D100004700](https://our.internmc.facebook.com/intern/diff/D100004700/)
SS-JIA pushed a commit that referenced this pull request Apr 8, 2026
Pull Request resolved: #18771

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.
ghstack-source-id: 364280900
@exported-using-ghexport

Differential Revision: [D100004700](https://our.internmc.facebook.com/intern/diff/D100004700/)
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
Pull Request resolved: pytorch#18771

When the same tensor is consumed by multiple ops that need a different
storage representation, the pass previously inserted a separate clone
transition for each consumer. Now it caches transition clones keyed by
(source_node, target_storage_type, target_layout) and reuses existing
clones when the same transition is needed again.

For Qwen3 0.6B (8da4w fp16), the embedding output (BUFFER due to
vocab_size exceeding texture limits) feeds both rms_norm and add which
need TEXTURE. Previously 2 clones were inserted; now 1 clone is shared.

Authored by Claude.
ghstack-source-id: 364280900
@exported-using-ghexport

Differential Revision: [D100004700](https://our.internmc.facebook.com/intern/diff/D100004700/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants