Skip to content

Qualcomm AI Engine Direct - UT fix#18787

Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:dev1/winskuo/UT_fix
Apr 9, 2026
Merged

Qualcomm AI Engine Direct - UT fix#18787
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:dev1/winskuo/UT_fix

Conversation

@winskuo-quic
Copy link
Copy Markdown
Collaborator

@winskuo-quic winskuo-quic commented Apr 9, 2026 •
edited
Loading

Summary

Currently we run UT like the following:
python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedUtils --model SM8750 --device ed8bb642 --build_folder build-android
This runs all tests under TestQNNQuantizedUtils. However, if the first test sets attributes like TestQNN.enable_profile=True, this will get carry over to rest of the tests and all tests will have enable_profile equals to True, which is not desired. This change takes advantage is setup function in UT to reset attributes back to False between executions.

Test plan

Passing all Utils tests under executorch/backends/qualcomm/tests/test_qnn_delegate.py

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 9, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18787

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f584c35 with merge base 137dedc (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/UT_fix branch from f8f6733 to f584c35 Compare April 9, 2026 08:23
@winskuo-quic winskuo-quic changed the title UT fix Qualcomm AI Engine Direct - UT fix Apr 9, 2026
@abhinaykukkadapu abhinaykukkadapu merged commit be370a1 into pytorch:main Apr 9, 2026
160 of 162 checks passed
jpiat pushed a commit to jpiat/executorch that referenced this pull request Apr 14, 2026
@winskuo-quic @jpiat
Qualcomm AI Engine Direct - UT fix (pytorch#18787)
e8416fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinaykukkadapu abhinaykukkadapu abhinaykukkadapu approved these changes

@cccclai cccclai Awaiting requested review from cccclai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winskuo-quic @abhinaykukkadapu