Skip to content

Add null checks to xnnpack flatbuffer #18799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucylq merged 1 commit into from
Apr 10, 2026
Merged

Add null checks to xnnpack flatbuffer #18799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion backends/xnnpack/runtime/XNNCompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,6 +1844,12 @@ ET_NODISCARD Error XNNCompiler::compileModel(
flatbuffers::GetBufferIdentifier(flatbuffer_data));

auto flatbuffer_graph = fb_xnnpack::GetXNNGraph(flatbuffer_data);
ET_CHECK_OR_RETURN_ERROR(
flatbuffer_graph != nullptr && flatbuffer_graph->xvalues() != nullptr &&
flatbuffer_graph->xnodes() != nullptr,
InvalidProgram,
"Failed to deserialize XNNPACK flatbuffer graph; null graph, xvalues, or xnodes.");
Comment on lines +1847 to +1851

// initialize xnnpack
xnn_status status = xnn_initialize(/*allocator =*/nullptr);
ET_CHECK_OR_RETURN_ERROR(
Expand All @@ -1853,9 +1859,18 @@ ET_NODISCARD Error XNNCompiler::compileModel(
xnn_status_to_string(status));

// create xnnpack subgraph
uint32_t num_externs = flatbuffer_graph->num_externs();
uint32_t num_values = flatbuffer_graph->xvalues()->size();
ET_CHECK_OR_RETURN_ERROR(
num_externs <= num_values,
InvalidProgram,
"num_externs (%u) exceeds total number of values (%u)",
num_externs,
num_values);

xnn_subgraph_t subgraph_ptr = nullptr;
status = xnn_create_subgraph(
/*external_value_ids=*/flatbuffer_graph->num_externs(),
/*external_value_ids=*/num_externs,
/*flags=*/0,
&subgraph_ptr);
ET_CHECK_OR_RETURN_ERROR(
Expand Down
Loading