Skip to content

Remove un-used copy from building dockers#18868

Merged
Erik-Lundell merged 1 commit intopytorch:mainfrom
Erik-Lundell:clean-build
Apr 24, 2026
Merged

Remove un-used copy from building dockers#18868
Erik-Lundell merged 1 commit intopytorch:mainfrom
Erik-Lundell:clean-build

Conversation

@Erik-Lundell
Copy link
Copy Markdown
Collaborator

@Erik-Lundell Erik-Lundell commented Apr 14, 2026

The removed copy seems to be stale, it is never used.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

The removed copy seems to be stale, it is never used.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I5d6e6a5f18a1fd69b1b38954bcbe4b73d887ea15
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18868

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 10 Cancelled Jobs, 3 Unrelated Failures

As of commit afdacf2 with merge base 2eaa16c (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2026
@Erik-Lundell Erik-Lundell added ciflow/trunk release notes: none Do not include this in the release notes partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 14, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2026
Comment thread .ci/docker/build.sh
# Copy requirements-lintrunner.txt from root to here
cp ../../requirements-lintrunner.txt ./

# Copy arm setup script from root to here
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, and this was a while ago, this was needed to make sure we get the latest files in the docker build for the PR we are testing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right, but I am not able to find any evidence of this being used. If you look at the PR that introduced it, https://github.com/pytorch/executorch/pull/1111/changes, ./arm is copied to the docker's /opt/arm to then run setup.sh. This code does not exist anymore. The only thing the ARM_SDK arg does is run install_arm.sh, which just installs some drivers.

Copy link
Copy Markdown
Collaborator

@zingo zingo Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when all deps a pip packages (even tosa-tools and MLSDK) we can and probably should clean out all stuff from the docker and use a plain one.
As a later improvements we can just prerun some pip installs to speed things up if we want.
e.g. I propose to merge this, cleanup old strange stuff and then maybe rethink the docker acceleration setup so we get a clean one. Would that be ok @digantdesai ?

@Erik-Lundell Erik-Lundell merged commit 98a1d66 into pytorch:main Apr 24, 2026
423 of 453 checks passed
zeel2104 pushed a commit to zeel2104/executorch that referenced this pull request May 5, 2026
The removed copy seems to be stale, it is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants