Skip to content

Remove un-used copy from building dockers #18868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Erik-Lundell merged 1 commit into from
Apr 24, 2026
Merged

Remove un-used copy from building dockers #18868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .ci/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/bin/bash
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
# Copyright 2026 Arm Limited and/or its affiliates.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
Expand Down Expand Up @@ -94,11 +95,6 @@ BUILD_DOCS=1
# Copy requirements-lintrunner.txt from root to here
cp ../../requirements-lintrunner.txt ./

# Copy arm setup script from root to here
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, and this was a while ago, this was needed to make sure we get the latest files in the docker build for the PR we are testing.

Copy link
Copy Markdown
Collaborator Author

@Erik-Lundell Erik-Lundell Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right, but I am not able to find any evidence of this being used. If you look at the PR that introduced it, https://github.com/pytorch/executorch/pull/1111/changes, ./arm is copied to the docker's /opt/arm to then run setup.sh. This code does not exist anymore. The only thing the ARM_SDK arg does is run install_arm.sh, which just installs some drivers.

Copy link
Copy Markdown
Collaborator

@zingo zingo Apr 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when all deps a pip packages (even tosa-tools and MLSDK) we can and probably should clean out all stuff from the docker and use a plain one.
As a later improvements we can just prerun some pip installs to speed things up if we want.
e.g. I propose to merge this, cleanup old strange stuff and then maybe rethink the docker acceleration setup so we get a clean one. Would that be ok @digantdesai ?

# TODO(huydhn): Figure out a way to rebuild the Docker image automatically
# with a new image hash when the content here is updated
cp -r ../../examples/arm/ ./arm

docker build \
--no-cache \
--progress=plain \
Expand Down
Loading