Skip to content

Make quantized_conv1d_depthwise kernels call the 2d optimized versions on HiFi (#18883)#18883

Merged
meta-codesync[bot] merged 2 commits intomainfrom
export-D99731352
Apr 16, 2026
Merged

Make quantized_conv1d_depthwise kernels call the 2d optimized versions on HiFi (#18883)#18883
meta-codesync[bot] merged 2 commits intomainfrom
export-D99731352

Conversation

@mcremon-meta
Copy link
Copy Markdown
Contributor

@mcremon-meta mcremon-meta commented Apr 14, 2026

Summary:

As titled.

Reviewed By: ethansfng

Differential Revision: D99731352

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18883

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 6e34a7e with merge base 2f339f0 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 14, 2026

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99731352.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:
Pull Request resolved: #18807

As titled. This makes it more readable, easier and will improve code size.

Differential Revision: D99509365
@meta-codesync meta-codesync Bot changed the title Make quantized_conv1d_depthwise kernels call the 2d optimized versions on HiFi Make quantized_conv1d_depthwise kernels call the 2d optimized versions on HiFi (#18883) Apr 16, 2026
meta-codesync Bot pushed a commit that referenced this pull request Apr 16, 2026
…s on HiFi (#18883)

Summary:

As titled.

Reviewed By: ethansfng

Differential Revision: D99731352
…s on HiFi (#18883)

Summary:
Pull Request resolved: #18883

As titled.

Reviewed By: ethansfng

Differential Revision: D99731352
@meta-codesync meta-codesync Bot merged commit 4b20342 into main Apr 16, 2026
165 of 170 checks passed
@meta-codesync meta-codesync Bot deleted the export-D99731352 branch April 16, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants