Skip to content

Disable VGF tests (#18899)#18899

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
digantdesai:export-D100808720
Apr 15, 2026
Merged

Disable VGF tests (#18899)#18899
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
digantdesai:export-D100808720

Conversation

@digantdesai
Copy link
Copy Markdown
Contributor

@digantdesai digantdesai commented Apr 14, 2026

Summary:

Temporary to unblock diff train.

Differential Revision: D100808720

Copilot AI review requested due to automatic review settings April 14, 2026 23:10
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18899

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 3315692 with merge base 87e65ac (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 14, 2026

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100808720.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Temporarily disables VGF-related ARM backend test setup to avoid Sandcastle seccomp-related crashes and unblock the diff train.

Changes:

  • Disabled VGF enablement flag in ARM test target generation (removes VGF-specific env/preloads).
  • Added skip_on_mode_mac = True to ARM pytest targets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

_ENABLE_VGF = True
_ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment suggests this is a Sandcastle-specific seccomp issue, but _ENABLE_VGF = False disables VGF-related env/preload deps for all builds. Either scope this flag to the environment(s) affected (e.g., Sandcastle-only) or update the comment to reflect that this is a global disable, and add a TODO/link to the tracking task/issue for re-enabling so it doesn’t become permanent by accident.

Suggested change
_ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run
# Disabled globally as a temporary workaround.
# Root cause: on Sandcastle, seccomp blocks `memfd_create`, which causes
# segfaults before the Python pre-flight check can run.
# TODO: Re-enable VGF once the Sandcastle seccomp issue is resolved, or
# scope this workaround to Sandcastle-only so other environments can use VGF.
_ENABLE_VGF = False

Copilot uses AI. Check for mistakes.
resources = ["conftest.py"],
compile = "with-source",
typing = False,
skip_on_mode_mac = True,
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip_on_mode_mac = True is applied to every python_pytest target generated in this loop, which effectively makes all ARM pytest targets opt out of mac mode. This isn’t mentioned in the PR description (which focuses on disabling VGF tests); please either document the rationale here / in the PR description, or narrow the skip to only the specific tests/mode(s) that actually need it.

Copilot uses AI. Check for mistakes.
Summary:

Temporary to unblock diff train.

Differential Revision: D100808720
@meta-codesync meta-codesync Bot changed the title Disable VGF tests Disable VGF tests (#18899) Apr 15, 2026
@meta-codesync meta-codesync Bot merged commit 75fe8e9 into pytorch:main Apr 15, 2026
161 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants