Disable VGF tests (#18899)#18899
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18899
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 3315692 with merge base 87e65ac ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100808720. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Temporarily disables VGF-related ARM backend test setup to avoid Sandcastle seccomp-related crashes and unblock the diff train.
Changes:
- Disabled VGF enablement flag in ARM test target generation (removes VGF-specific env/preloads).
- Added
skip_on_mode_mac = Trueto ARM pytest targets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") | ||
|
|
||
| _ENABLE_VGF = True | ||
| _ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run |
There was a problem hiding this comment.
The inline comment suggests this is a Sandcastle-specific seccomp issue, but _ENABLE_VGF = False disables VGF-related env/preload deps for all builds. Either scope this flag to the environment(s) affected (e.g., Sandcastle-only) or update the comment to reflect that this is a global disable, and add a TODO/link to the tracking task/issue for re-enabling so it doesn’t become permanent by accident.
| _ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run | |
| # Disabled globally as a temporary workaround. | |
| # Root cause: on Sandcastle, seccomp blocks `memfd_create`, which causes | |
| # segfaults before the Python pre-flight check can run. | |
| # TODO: Re-enable VGF once the Sandcastle seccomp issue is resolved, or | |
| # scope this workaround to Sandcastle-only so other environments can use VGF. | |
| _ENABLE_VGF = False |
| resources = ["conftest.py"], | ||
| compile = "with-source", | ||
| typing = False, | ||
| skip_on_mode_mac = True, |
There was a problem hiding this comment.
skip_on_mode_mac = True is applied to every python_pytest target generated in this loop, which effectively makes all ARM pytest targets opt out of mac mode. This isn’t mentioned in the PR description (which focuses on disabling VGF tests); please either document the rationale here / in the PR description, or narrow the skip to only the specific tests/mode(s) that actually need it.
Summary: Temporary to unblock diff train. Differential Revision: D100808720
428727b to
3315692
Compare
Summary:
Temporary to unblock diff train.
Differential Revision: D100808720