Skip to content

Disable VGF tests (#18899) #18899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Apr 15, 2026
Merged

Disable VGF tests (#18899) #18899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions backends/arm/test/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ load("@fbcode_macros//build_defs:python_pytest.bzl", "python_pytest")
load("@bazel_skylib//lib:paths.bzl", "paths")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

_ENABLE_VGF = True
_ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment suggests this is a Sandcastle-specific seccomp issue, but _ENABLE_VGF = False disables VGF-related env/preload deps for all builds. Either scope this flag to the environment(s) affected (e.g., Sandcastle-only) or update the comment to reflect that this is a global disable, and add a TODO/link to the tracking task/issue for re-enabling so it doesn’t become permanent by accident.

Suggested change
_ENABLE_VGF = False # Disabled: memfd_create blocked by seccomp on Sandcastle causes segfaults before Python pre-flight check can run
# Disabled globally as a temporary workaround.
# Root cause: on Sandcastle, seccomp blocks `memfd_create`, which causes
# segfaults before the Python pre-flight check can run.
# TODO: Re-enable VGF once the Sandcastle seccomp issue is resolved, or
# scope this workaround to Sandcastle-only so other environments can use VGF.
_ENABLE_VGF = False

Copilot uses AI. Check for mistakes.

def define_arm_tests():
# TODO [fbonly] Add more tests
Expand Down Expand Up @@ -72,6 +72,7 @@ def define_arm_tests():
resources = ["conftest.py"],
compile = "with-source",
typing = False,
skip_on_mode_mac = True,
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip_on_mode_mac = True is applied to every python_pytest target generated in this loop, which effectively makes all ARM pytest targets opt out of mac mode. This isn’t mentioned in the PR description (which focuses on disabling VGF tests); please either document the rationale here / in the PR description, or narrow the skip to only the specific tests/mode(s) that actually need it.

Copilot uses AI. Check for mistakes.
env = {} if runtime.is_oss else ({
"MODEL_CONVERTER_PATH": "$(location fbsource//third-party/pypi/ai-ml-sdk-model-converter/0.8.0:model-converter-bin)",
"MODEL_CONVERTER_LIB_DIR": "$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64",
Expand All @@ -81,12 +82,11 @@ def define_arm_tests():
"EMULATION_LAYER_TENSOR_JSON": "$(location fbsource//third-party/arm-ml-emulation-layer/v0.9.0/src:VkLayer_Tensor_json)",
"EMULATION_LAYER_GRAPH_JSON": "$(location fbsource//third-party/arm-ml-emulation-layer/v0.9.0/src:VkLayer_Graph_json)",
} if _ENABLE_VGF else {}),
preload_deps = [
preload_deps = [] if runtime.is_oss or not _ENABLE_VGF else [
"//executorch/kernels/quantized:custom_ops_generated_lib",
] + ([] if runtime.is_oss or not _ENABLE_VGF else [
"fbsource//third-party/khronos:vulkan",
"//executorch/backends/arm/runtime:vgf_backend",
]),
],
deps = [
"//executorch/backends/arm/test:arm_tester" if runtime.is_oss else "//executorch/backends/arm/test/tester/fb:arm_tester_fb",
"//executorch/backends/arm/test:conftest",
Expand Down
Loading